Dashboard: Settings UI #2920
Merged
Dashboard: Settings UI #2920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BrittanyIRL
added
Type: Enhancement
Codecov Report
@@ Coverage Diff @@
## master #2920 +/- ##
==========================================
- Coverage 81.49% 81.15% -0.34%
==========================================
Files 704 714 +10
Lines 11953 12016 +63
==========================================
+ Hits 9741 9752 +11
- Misses 2212 2264 +52
|
|
Size Change: +1 kB (0%) Total Size: 1 MB
ℹ️ View Unchanged
|
BrittanyIRL
commented
Jul 1, 2020
Comment on lines
-128
to
+136
| handleSortChange={useCallback( | ||
| (newSort) => { | ||
| sort.set(newSort); | ||
| scrollToTop(); | ||
| }, | ||
| [scrollToTop, sort] | ||
| )} | ||
| handleSortChange={onSortChange} |
There was a problem hiding this comment.
this is just a nit that pascal asked for yesterday in the rush for beta, making good on the update :D
BrittanyIRL
force-pushed
the
feature/2747-initial-ui
branch
from
7907198 to
7e9c097
Compare
swissspidy
reviewed
Jul 2, 2020
assets/src/dashboard/app/views/editorSettings/googleAnalytics/index.js
Outdated
Show resolved
Hide resolved
swissspidy
reviewed
Jul 2, 2020
BrittanyIRL
force-pushed
the
feature/2747-initial-ui
branch
from
b433126 to
e239f98
Compare
BrittanyIRL
commented
Jul 3, 2020
mariano-formidable
approved these changes
Jul 6, 2020
| <div> | ||
| <FileUploadHelperText>{TEXT.context}</FileUploadHelperText> | ||
| <UploadContainer> | ||
| <p>{'Upload Placeholder'}</p> |
There was a problem hiding this comment.
How come "Upload Placeholder" isn't part of the TEXT const?
There was a problem hiding this comment.
because it will go away when this section gets fleshed out to be a file uploader. It's literally just a placeholder visually right now.
…a described by for GA input
…s so adjusting accordingly
BrittanyIRL
force-pushed
the
feature/2747-initial-ui
branch
from
7a12e6a to
fae8cc6
Compare
carloskelly13
approved these changes
Jul 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Lays groundwork for rest of settings page within the dashboard - file structure and the base UI brought in from Figma.
Relevant Technical Choices
To-do
(These will all be separate)
User-facing changes
Testing Instructions
Addresses #2747