Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump @wordpress/eslint-plugin from 5.0.1 to 5.1.0 #1394

Merged
merged 2 commits into from
Apr 30, 2020
Merged

Bump @wordpress/eslint-plugin from 5.0.1 to 5.1.0 #1394

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
884e045
Bump @wordpress/eslint-plugin from 5.0.1 to 5.1.0
dependabot-preview[bot] Apr 30, 2020
3133a59
Remove now unnecessary eslint disable comments
swissspidy Apr 30, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion assets/src/edit-story/components/canvas/displayElement.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,6 @@ function DisplayElement({ element, previewMode, page }) {
: null;

const { id, opacity, type, isBackground } = element;
//eslint-disable-next-line @wordpress/no-unused-vars-before-return
const { Display } = getDefinitionForType(type);
const { Display: Replacement } =
getDefinitionForType(replacement?.type) || {};
Expand Down
1 change: 0 additions & 1 deletion assets/src/edit-story/components/canvas/editElement.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,6 @@ function EditElement({ element }) {
actions: { getBox },
} = useUnits();

//eslint-disable-next-line @wordpress/no-unused-vars-before-return
const { Edit } = getDefinitionForType(type);
const box = getBox(element);

Expand Down
1 change: 0 additions & 1 deletion assets/src/edit-story/components/canvas/useCanvasSelectionCopyPaste.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,6 @@ function useCanvasSelectionCopyPaste(container) {

const htmlContent = selectedElements
.map(({ type, ...rest }) => {
// eslint-disable-next-line @wordpress/no-unused-vars-before-return
const { Output } = getDefinitionForType(type);
return renderToStaticMarkup(
<Output element={rest} box={{ width: 100, height: 100 }} />
Expand Down
1 change: 0 additions & 1 deletion assets/src/edit-story/output/element.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@ import WithLink from '../components/link/output';
function OutputElement({ element }) {
const { id, opacity, type } = element;

// eslint-disable-next-line @wordpress/no-unused-vars-before-return
const { Output } = getDefinitionForType(type);

// Box is calculated based on the 100%:100% basis for width and height
Expand Down
6 changes: 3 additions & 3 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@
"@wordpress/babel-plugin-import-jsx-pragma": "^2.5.0",
"@wordpress/dependency-extraction-webpack-plugin": "^2.6.0",
"@wordpress/e2e-test-utils": "^4.6.0",
"@wordpress/eslint-plugin": "^5.0.1",
"@wordpress/eslint-plugin": "^5.1.0",
"@wordpress/jest-console": "^3.6.0",
"@wordpress/jest-puppeteer-axe": "^1.8.0",
"amphtml-validator": "^1.0.30",
Expand Down