Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save snapshots on e2e test failures #11786

Merged
merged 4 commits into from
Jun 24, 2022
Merged

Save snapshots on e2e test failures #11786

merged 4 commits into from
Jun 24, 2022

Conversation

swissspidy
Copy link
Collaborator

@swissspidy swissspidy commented Jun 23, 2022

Context

Summary

Relevant Technical Choices

Uses a similar approach than what Gutenberg ended up doing. Just without forking the jest-environment-puppeteer dependency.

To-do

A PR comment with a link to the uploaded artifact could be nice, making it easier discoverable.

User-facing changes

Testing Instructions

  • This is a non-user-facing change and requires no QA

This PR can be tested by following these steps:

Reviews

Does this PR have a security-related impact?

Does this PR change what data or activity we track or use?

Does this PR have a legal-related impact?

Checklist

  • This PR addresses an existing issue and I have linked this PR to it in ZenHub
  • I have tested this code to the best of my abilities
  • I have verified accessibility to the best of my abilities (docs)
  • I have verified i18n and l10n (translation, right-to-left layout) to the best of my abilities
  • This code is covered by automated tests (unit, integration, and/or e2e) to verify it works as intended (docs)
  • I have added documentation where necessary
  • I have added a matching Type: XYZ label to the PR

Fixes #7550

@swissspidy swissspidy added Type: Infrastructure Changes impacting testing infrastructure or build tooling Pod: WP labels Jun 23, 2022
@swissspidy swissspidy requested a review from timarney June 23, 2022 15:50
@swissspidy swissspidy changed the title Save snapshots on e2e test failures [WIP] Save snapshots on e2e test failures Jun 23, 2022
@swissspidy swissspidy requested a review from spacedmonkey June 23, 2022 15:50
@swissspidy swissspidy marked this pull request as ready for review June 24, 2022 15:35
@swissspidy swissspidy changed the title [WIP] Save snapshots on e2e test failures Save snapshots on e2e test failures Jun 24, 2022
@swissspidy swissspidy requested a review from timarney June 24, 2022 15:37
Copy link
Contributor

@timarney timarney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@swissspidy swissspidy merged commit 5fd62c1 into main Jun 24, 2022
@swissspidy swissspidy deleted the try/7550-e2e-screenshot branch June 24, 2022 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Infrastructure Changes impacting testing infrastructure or build tooling
Projects
None yet
Development

Successfully merging this pull request may close these issues.

E2E Tests: take screenshots on failures
2 participants