-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Website: Improve storage for static assets #5961
Comments
@choumx would love to hear your thoughts on that |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
I don't have experience with it but Git LFS sounds promising due to git versioning and GitHub support. It should be very inexpensive for our expected usage. |
I'm a bit worried about the steps required to turn off LFS again if needed, but we can give it a try. No matter what option we choose, the current repo size will probably remain the same since git history is left untouched. |
We could purge history for the template assets. It might speed up some of our CI steps. |
Checking out the repo in CI only takes a couple of seconds, don't think we can speed that up more. Any improvements due to purging history would mostly benefit contributors cloning the repo. Right now new contributors will clone 1GB worth of files even when never using the |
Documenting the steps required to set up Git LFS (WIP):
And here's what I've been doing to migrate the
All contributors modifying assets in Note: I am not updating the website images+videos to use LFS with this (yet). But it could be done: git lfs track "./public/img/*.png"
git lfs track "./public/img/**/*.png"
git lfs track "./public/img/*.jpg"
git lfs track "./public/img/**/*.jpg"
git lfs track "./public/video/*.mp4"
git lfs track "./public/video/**/*.mp4"
git lfs track "./public/video/*.webm"
git lfs track "./public/video/**/*.webm"
git lfs migrate info static-site --include="public/img/*.png,public/img/**/*.png,public/img/*.jpg,public/img/**/*.jpg,public/video/*.mp4,public/video/**/*.mp4,public/video/*.webm,public/video/**/*.webm"
git lfs migrate import static-site --include="public/img/*.png,public/img/**/*.png,public/img/*.jpg,public/img/**/*.jpg,public/video/*.mp4,public/video/**/*.mp4,public/video/*.webm,public/video/**/*.webm" |
Closing for now |
Please be very brave and remove those files with their commit history breaking all forks but |
Downloading 1.17 GB of data makes contributors go away. |
Task Description
This is a long-standing open to-do item related to our static assets hosting. With more templates in the making, the repo size will grow considerably, so we need a solution here.
We can keep the microsite and small images in
static-site
as today, but the template assets we should move at some point.In other words:
There will be 50 templates that we need to host somewhere and make available via some API.
Some thoughts:
Current git-sizer output
The text was updated successfully, but these errors were encountered: