Skip to content

Commit

Permalink
Add missing title dialog (#4251)
Browse files Browse the repository at this point in the history
* Added a new dialog in case story title is missing

* Added infrastructure to access title input

* Updated wording and layout of dialog

* Refactored header buttons to multiple files

* Fixed link and formatting

* Amended unit tests of publish button with new feature

* Updated unit tests to cover even more cases

* Added onClose to titleMissingDialog

* Added storybook story for `titleMissingDialig`

* Added karma test with screenshot for missing title dialog

* Fixed nit

Co-authored-by: Pascal Birchler <[email protected]>
  • Loading branch information
Morten Barklund and swissspidy authored Sep 8, 2020
1 parent 505b8d8 commit ef538af
Show file tree
Hide file tree
Showing 18 changed files with 1,049 additions and 396 deletions.
5 changes: 4 additions & 1 deletion assets/src/edit-story/components/dialog/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,8 @@ import { rgba } from 'polished';
*/
import Modal from '../modal';

export const TRANSITION_DURATION = 300;

// Shadow styles ported from @material-ui/Dialog
const DialogBox = styled.div`
border-radius: 4px;
Expand All @@ -40,7 +42,8 @@ const DialogBox = styled.div`
0px 24px 38px 3px ${({ theme }) => rgba(theme.colors.bg.black, 0.14)},
0px 9px 46px 8px ${({ theme }) => rgba(theme.colors.bg.black, 0.12)};
color: ${({ theme }) => rgba(theme.colors.bg.black, 0.87)};
transition: box-shadow 300ms cubic-bezier(0.4, 0, 0.2, 1) 0ms;
transition: box-shadow ${TRANSITION_DURATION}ms cubic-bezier(0.4, 0, 0.2, 1)
0ms;
background-color: ${({ theme }) => theme.colors.fg.white};
`;

Expand Down
354 changes: 0 additions & 354 deletions assets/src/edit-story/components/header/buttons.js

This file was deleted.

Loading

0 comments on commit ef538af

Please sign in to comment.