Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for signal handling #917

Merged
merged 1 commit into from
Aug 22, 2018

Conversation

dgageot
Copy link
Contributor

@dgageot dgageot commented Aug 22, 2018

Signed-off-by: David Gageot [email protected]

Signed-off-by: David Gageot <[email protected]>
@codecov-io
Copy link

Codecov Report

Merging #917 into master will increase coverage by 0.36%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #917      +/-   ##
==========================================
+ Coverage   39.01%   39.38%   +0.36%     
==========================================
  Files          60       61       +1     
  Lines        2609     2613       +4     
==========================================
+ Hits         1018     1029      +11     
+ Misses       1478     1471       -7     
  Partials      113      113
Impacted Files Coverage Δ
cmd/skaffold/app/cmd/dev.go 0% <ø> (ø) ⬆️
cmd/skaffold/app/cmd/signals.go 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6581755...0b3e93b. Read the comment docs.

Copy link
Contributor

@balopat balopat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dgageot dgageot merged commit 47865e3 into GoogleContainerTools:master Aug 22, 2018
@dgageot dgageot deleted the test-ctrlc branch December 28, 2018 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants