feat: Add Sprig template functions #9005
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use -- conventional-commit-lint bot |
briantopping
force-pushed
the
sprig
branch
2 times, most recently
from
00db1e7
to
092f37b
Compare
briantopping
changed the title
Signed-off-by: Brian Topping <[email protected]>
Signed-off-by: Brian Topping <[email protected]>
|
Hi @ericzzzzzzz, I missed the test failure before, should be fixed. Apologies for the noise. |
no worries, I just re-triggered the build. |
Signed-off-by: Brian Topping <[email protected]>
|
@ericzzzzzzz I guess I am learning what has to happen the hard way on my first PR. Doesn't seem I can add that label to kick off a build. |
ericzzzzzzz
approved these changes
Aug 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add Sprig template functions. This allows parameterizing with functions such as
dateUser facing changes (remove if N/A)
Additional functions are available to templated fields. No other changes are made to existing APIs or UX.
Tests for the functions are comprehensively provided upstream.