Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix version in released docker image #878

Merged
merged 1 commit into from
Aug 6, 2018

Conversation

r2d4
Copy link
Contributor

@r2d4 r2d4 commented Aug 6, 2018

since the build happens inside docker, we have to pass through the overridden version info

https://kubernetes.slack.com/archives/CABQMSZA6/p1533571310000477?thread_ts=1533292054.000118&cid=CABQMSZA6

Copy link
Contributor

@balopat balopat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@r2d4 r2d4 merged commit 5382fed into GoogleContainerTools:master Aug 6, 2018
@r2d4 r2d4 deleted the fix-version-in-image branch August 6, 2018 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants