Update check #866
Merged
Update check #866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixes #148 |
balopat
reviewed
Aug 2, 2018
cmd/skaffold/app/cmd/cmd.go
Outdated
| return errors.Wrap(err, "getting latest version") | ||
| } | ||
| if latest.GT(current) { | ||
| ch <- fmt.Sprintf("There is a new version (%s) of skaffold available.", latest) |
There was a problem hiding this comment.
nit: provide a download link
|
We should also probably tell users how to disable this by setting |
|
agreed - probably in the doc, but also could put a debugf message here every time the update check runs would say something like: "running update check...you can disable this by setting the SKAFFOLD_UPDATE_CHECK env var false" |
dlorenc
approved these changes
Aug 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
merge this after this release