-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add support for helm image convention vs fqn setting #826
Conversation
Could we please see another release (9.1?) when this is merged! |
@r2d4 Wouldn't it be better to default to the helm convention? I can fix the example to match the new default. I'm aware it will be a breaking change but it will support a much wider range of Helm charts. |
I don't want to break users current config, even if its really the right behavior. What do you think about leaving the default behavior as is for now, and then we can merge the feature, try it out, and migrate to |
We can even use |
You're right. Better roll it slow and only enable for users who try the new version. I'll update the behavior accordingly. |
Thanks! |
This addresses the issue described in #360
It will enable the user to determine if the image setup schema is using fully qualified named vs the Helm standard of
image.repository
andimage.tag