Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for helm image convention vs fqn setting #826

Merged
merged 6 commits into from
Jul 30, 2018

Conversation

bivas
Copy link
Contributor

@bivas bivas commented Jul 17, 2018

This addresses the issue described in #360
It will enable the user to determine if the image setup schema is using fully qualified named vs the Helm standard of image.repository and image.tag

@r2d4 r2d4 self-assigned this Jul 18, 2018
@r2d4 r2d4 added the kokoro:run runs the kokoro jobs on a PR label Jul 18, 2018
@kokoro-team kokoro-team removed the kokoro:run runs the kokoro jobs on a PR label Jul 18, 2018
@wstrange
Copy link
Contributor

Could we please see another release (9.1?) when this is merged!

@r2d4
Copy link
Contributor

r2d4 commented Jul 19, 2018

@bivas looks like this is a breaking change for the helm config, can we add this but default to the existing behavior?

@wstrange Once this gets in we'll do another release

@bivas
Copy link
Contributor Author

bivas commented Jul 19, 2018

@r2d4 Wouldn't it be better to default to the helm convention? I can fix the example to match the new default. I'm aware it will be a breaking change but it will support a much wider range of Helm charts.

@r2d4
Copy link
Contributor

r2d4 commented Jul 19, 2018

I don't want to break users current config, even if its really the right behavior. What do you think about leaving the default behavior as is for now, and then we can merge the feature, try it out, and migrate to skaffold/v1alpha3 config and swap the defaults?

@r2d4
Copy link
Contributor

r2d4 commented Jul 19, 2018

We can even use skaffold fix to perform that for users automatically

@bivas
Copy link
Contributor Author

bivas commented Jul 19, 2018

You're right. Better roll it slow and only enable for users who try the new version.

I'll update the behavior accordingly.

@dgageot dgageot added the kokoro:run runs the kokoro jobs on a PR label Jul 24, 2018
@kokoro-team kokoro-team removed the kokoro:run runs the kokoro jobs on a PR label Jul 24, 2018
@bivas
Copy link
Contributor Author

bivas commented Jul 30, 2018

@r2d4 @dgageot Can we progress with this?

@r2d4 r2d4 added the kokoro:run runs the kokoro jobs on a PR label Jul 30, 2018
@r2d4
Copy link
Contributor

r2d4 commented Jul 30, 2018

Thanks!

@r2d4 r2d4 merged commit aeaecfb into GoogleContainerTools:master Jul 30, 2018
@bivas bivas deleted the fix-issue-360 branch August 5, 2018 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kokoro:run runs the kokoro jobs on a PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants