Try to guess GCB projectID from the image name #809
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a GCB projectId is not provided, we try to get the project from the names of the images. Signed-off-by: David Gageot <[email protected]>
r2d4
reviewed
Jul 11, 2018
| } | ||
|
|
||
| index := repoInfo.Index | ||
| if !index.Official { |
There was a problem hiding this comment.
@jonjohnsonjr is there a cleaner way to do this in go-containerregistry?
There was a problem hiding this comment.
It might be a little bit cleaner to use ggcr, but you're going to end up having to do string surgery regardless, so I wouldn't bother.
There's no notion of "Official" images on GCR, so this isn't super meaningful.
This also won't work for domain-scoped projects, though those are pretty long deprecated by now.
r2d4
approved these changes
Jul 11, 2018
r2d4
approved these changes
Jul 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a GCB projectId is not provided, we try to get the project from the names of the images.
That helps writing skaffold that are a bit more portable.
Signed-off-by: David Gageot [email protected]