Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

helm: add deploy dependency paths #765

Merged
merged 1 commit into from
Jun 29, 2018
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions pkg/skaffold/deploy/helm.go
Original file line number Diff line number Diff line change
Expand Up @@ -74,9 +74,18 @@ func (h *HelmDeployer) Deploy(ctx context.Context, out io.Writer, builds []build
return deployResults, nil
}

// Not implemented
func (h *HelmDeployer) Dependencies() ([]string, error) {
return nil, nil
var deps []string
for _, release := range h.Releases {
deps = append(deps, release.ValuesFilePath)
filepath.Walk(release.ChartPath, func(path string, info os.FileInfo, err error) error {
if !info.IsDir() {
deps = append(deps, path)
}
return nil
})
}
return deps, nil
}

// Cleanup deletes what was deployed by calling Deploy.
Expand Down