Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ko): Default repo for pushing ko:// images #7010

Merged
merged 2 commits into from
Jan 13, 2022

Commits on Jan 12, 2022

  1. fix(ko): Default repo for pushing ko:// images

    When using the `ko://` scheme prefix for the Skaffold image name, the
    rest of the image name, following the prefix, is a Go import path.
    
    This import path maps to the Git repository (typically), and won't match
    an image registry name (e.g., `ko://github.com/org/repo` vs
    `gcr.io/project_id`).
    
    With this change, if _all_ of the following are true, the build results
    in an error that instructs the user to set the default repo:
    
    - the image name in `skaffold.yaml` uses the `ko://` prefix; and
    - the Skaffold default repo is _not_ set; and
    - the image is being pushed to a registry (rather than sideloaded to a
      Docker daemon).
    
    Fixes: GoogleContainerTools#6933
    Tracking: GoogleContainerTools#6041
    halvards committed Jan 12, 2022
    Configuration menu
    Copy the full SHA
    d15f959 View commit details
    Browse the repository at this point in the history
  2. docs(ko): Default repo for ko:// prefixed images

    Document that `ko` builder users who use the `ko://` prefix must set the
    default repo if pushing images to a registry.
    
    Related: GoogleContainerTools#6933
    Tracking: GoogleContainerTools#6041
    halvards committed Jan 12, 2022
    Configuration menu
    Copy the full SHA
    1d4388a View commit details
    Browse the repository at this point in the history