-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add WSL support #694
add WSL support #694
Conversation
pkg/skaffold/docker/client.go
Outdated
@@ -43,10 +46,15 @@ var ( | |||
dockerAPIClientOnce sync.Once | |||
dockerAPIClient APIClient | |||
dockerAPIClientErr error | |||
procVerDetect bool | |||
isWsl bool |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not a fan of having this at both the package level and set through a function. Could we drop this here and always return the result of detectWsl?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
then we don't cache. Ok.
pkg/skaffold/docker/client.go
Outdated
} | ||
|
||
func getMiniKubeFilename() (string, error) { | ||
const winMiniKubeEnv = "SKAFFOLD_WINDOWS_MINIKUBE" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you move this constant to the package level?
pkg/skaffold/docker/client.go
Outdated
func getMiniKubeFilename() (string, error) { | ||
const winMiniKubeEnv = "SKAFFOLD_WINDOWS_MINIKUBE" | ||
if found, _ := detectWsl(); found { | ||
filename, envExists := os.LookupEnv(winMiniKubeEnv) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it make more sense to use exec.LookPath with minikube.exe instead of this environment variable to find the path to Minikube?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good idea. done.
Sent #698 to fix that. |
add WSL support #523
The DOCKER_CERT_PATH environment will be changed with
wslpath
tool.Here you find a documentation how one can use minikube on windows:
After this installation one need to correct the kube config with: