Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release: v1.35.0 #6868

Merged
merged 2 commits into from
Nov 16, 2021
Merged

release: v1.35.0 #6868

merged 2 commits into from
Nov 16, 2021

Conversation

tejal29
Copy link
Member

@tejal29 tejal29 commented Nov 16, 2021

Release v1.35.0!

@tejal29 tejal29 requested a review from a team as a code owner November 16, 2021 18:29
@google-cla google-cla bot added the cla: yes label Nov 16, 2021
@codecov
Copy link

codecov bot commented Nov 16, 2021

Codecov Report

Merging #6868 (433c107) into main (290280e) will decrease coverage by 1.34%.
The diff coverage is 61.83%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #6868      +/-   ##
==========================================
- Coverage   70.48%   69.13%   -1.35%     
==========================================
  Files         515      547      +32     
  Lines       23150    25080    +1930     
==========================================
+ Hits        16317    17339    +1022     
- Misses       5776     6576     +800     
- Partials     1057     1165     +108     
Impacted Files Coverage Δ
cmd/skaffold/app/cmd/deploy.go 52.00% <ø> (-1.85%) ⬇️
cmd/skaffold/app/cmd/dev.go 84.61% <0.00%> (ø)
cmd/skaffold/app/cmd/flags.go 91.00% <0.00%> (+0.18%) ⬆️
cmd/skaffold/app/cmd/render.go 36.66% <0.00%> (-4.72%) ⬇️
cmd/skaffold/skaffold.go 0.00% <0.00%> (ø)
cmd/skaffold/app/cmd/inspect_tests.go 62.50% <14.28%> (-1.14%) ⬇️
cmd/skaffold/app/cmd/fix.go 68.85% <40.00%> (-7.62%) ⬇️
cmd/skaffold/app/cmd/lint.go 42.85% <42.85%> (ø)
cmd/skaffold/app/cmd/find_configs.go 48.88% <50.00%> (+0.24%) ⬆️
cmd/skaffold/app/skaffold.go 76.19% <70.00%> (-8.43%) ⬇️
... and 163 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 70eba2a...433c107. Read the comment docs.

Copy link
Member

@briandealwis briandealwis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit

CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Contributor

@nkubala nkubala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

conventional commit messages are definitely nice, but they don't really make our patch notes look very good....maybe we should remove the prefixes for the patch notes?

CHANGELOG.md Outdated
Note: This release comes with a new config version, `v2beta26`. To upgrade your skaffold.yaml, use `skaffold fix`. If you choose not to upgrade, skaffold will auto-upgrade as best as it can.

Highlights:
* Skaffold's native support for `ko` builder for golang projects. Please try it out and let us [know](https://skaffold.dev/docs/pipeline-stages/builders/ko/)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Skaffold's native support for `ko` builder for golang projects. Please try it out and let us [know](https://skaffold.dev/docs/pipeline-stages/builders/ko/)
* Skaffold now natively supports building Go projects with [`ko`](https://github.com/google/ko)! Check out the [documentation](https://skaffold.dev/docs/pipeline-stages/builders/ko/) for more information on how it works with Skaffold projects.

CHANGELOG.md Outdated

Highlights:
* Skaffold's native support for `ko` builder for golang projects. Please try it out and let us [know](https://skaffold.dev/docs/pipeline-stages/builders/ko/)
* Skaffold performs status-check for stateful sets [#6828](https://github.com/GoogleContainerTools/skaffold/pull/6828)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Skaffold performs status-check for stateful sets [#6828](https://github.com/GoogleContainerTools/skaffold/pull/6828)
* Skaffold now performs status-check for `StatefulSet` resources

CHANGELOG.md Outdated
Comment on lines 111 to 113
- Tejal Desai
- dependabot[bot]
- jrcast
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Tejal Desai
- dependabot[bot]
- jrcast
- Tejal Desai
- jrcast

Copy link
Contributor

@aaron-prindle aaron-prindle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

don't thank dependabot
@tejal29 tejal29 merged commit e9c900f into GoogleContainerTools:main Nov 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants