Update go-containerregistry #651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: David Gageot <[email protected]>
dlorenc
reviewed
Jun 8, 2018
| MountPaths: []name.Repository{ref.Context()}, | ||
| } | ||
| return remote.Write(targetRef, img, auth, t, wo) | ||
| return remote.Write(targetRef, img, auth, t, remote.WriteOptions{}) |
There was a problem hiding this comment.
I think we want to keep MountOptions if we can.
There was a problem hiding this comment.
MountPaths field was removed. I don't know if something else needs to be done. @jonjohnsonjr @mattmoor ?
There was a problem hiding this comment.
The happy path for mounting is now handled by the library, see google/go-containerregistry#186
tl;dr: remote layer reads retain the source repo and we specialize that case on remote layer writes to mount from where it was read, so you shouldn't need to do anything now :)
There was a problem hiding this comment.
Ah, nice. Missed that change in the library somehow.
|
LGTM |
dlorenc
approved these changes
Jun 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't know what I'm doing here.
@jonjohnsonjr could you please take a look at what I had to change in pkg/skaffold/docker/image.go?
Thanks!
Signed-off-by: David Gageot [email protected]