Implement Target support for ko builder #6447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This implements support for the Target config field for the ko builder. The Target field allows users to specify a target for `go build`. This is necessary where the main package is not in the context directory. Tracking: GoogleContainerTools#6041 Related: GoogleContainerTools#6054, GoogleContainerTools#6437
Codecov Report
@@ Coverage Diff @@
## main #6447 +/- ##
==========================================
+ Coverage 70.41% 70.42% +0.01%
==========================================
Files 506 506
Lines 22847 22850 +3
==========================================
+ Hits 16087 16093 +6
+ Misses 5708 5705 -3
Partials 1052 1052
Continue to review full report at Codecov.
|
tejal29
approved these changes
Aug 17, 2021
| @@ -36,6 +36,14 @@ type KoArtifact struct { | |||
| // Defaults to `all` to build for all platforms supported by the | |||
| // base image. | |||
| Platforms []string `yaml:"platforms,omitempty"` | |||
|
|
|||
There was a problem hiding this comment.
👍 for temporary schema changes file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This implements support for the
Targetconfig field for the ko builder.The
Targetfield allows users to specify a target forgo build. This is necessary where the main package is not in the context directory.Creates a
testdatadirectory under./pkg/skaffold/build/kowith test samples. This is to avoid depending on test samples from other packages.Tracking: #6041
Related: #6054, #6437