Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various small UX improvements #6426

Merged
merged 1 commit into from
Aug 16, 2021

Conversation

nkubala
Copy link
Contributor

@nkubala nkubala commented Aug 12, 2021

  • Consistent capitalization in docs
  • Move skaffold fix out of "Pipeline Building Blocks"
  • Hide the skaffold schema and skaffold credits commands
  • Fix the available log levels
  • Remove feature maturities from command help text

@nkubala nkubala requested a review from a team as a code owner August 12, 2021 23:05
@google-cla google-cla bot added the cla: yes label Aug 12, 2021
@codecov
Copy link

codecov bot commented Aug 13, 2021

Codecov Report

Merging #6426 (cce61ac) into main (5ceca63) will decrease coverage by 0.08%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #6426      +/-   ##
==========================================
- Coverage   70.48%   70.40%   -0.09%     
==========================================
  Files         498      505       +7     
  Lines       22593    22842     +249     
==========================================
+ Hits        15925    16082     +157     
- Misses       5638     5708      +70     
- Partials     1030     1052      +22     
Impacted Files Coverage Δ
cmd/skaffold/app/cmd/cmd.go 71.05% <100.00%> (-0.46%) ⬇️
cmd/skaffold/app/cmd/config.go 100.00% <100.00%> (ø)
cmd/skaffold/app/cmd/credits.go 100.00% <100.00%> (ø)
cmd/skaffold/app/cmd/debug.go 100.00% <100.00%> (ø)
cmd/skaffold/app/cmd/delete.go 55.55% <100.00%> (ø)
cmd/skaffold/app/cmd/filter.go 25.00% <100.00%> (ø)
cmd/skaffold/app/cmd/init.go 100.00% <100.00%> (ø)
cmd/skaffold/app/cmd/render.go 41.37% <100.00%> (ø)
cmd/skaffold/app/cmd/schema.go 83.33% <100.00%> (+0.72%) ⬆️
pkg/skaffold/event/v2/status_check.go 85.45% <0.00%> (-14.55%) ⬇️
... and 47 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5ceca63...cce61ac. Read the comment docs.

@tejal29
Copy link
Member

tejal29 commented Aug 13, 2021

  • Hide the skaffold schema and skaffold credits commands

I think skaffold credits command is a legal requirement. It is to make sure anyone using skaffold knows which licenses etc users are pulling in. I feel we should keep it on the docs page for visibility.

Copy link
Contributor

@aaron-prindle aaron-prindle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tejal29 tejal29 merged commit 224e8c3 into GoogleContainerTools:main Aug 16, 2021
@nkubala nkubala deleted the ux-improvements branch August 17, 2021 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants