Remove no-manifest code. #640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlorenc
reviewed
Jun 6, 2018
| return nil, errors.Wrap(err, "reading dockerfile") | ||
| } | ||
|
|
||
| ports, err := docker.PortsFromDockerfile(r) |
There was a problem hiding this comment.
You should also be able to delete this function from the docker package: PortsFromDockerfile and tests.
There was a problem hiding this comment.
Thanks @dlorenc I removed it too now
r2d4
reviewed
Jun 6, 2018
|
@r2d4 changes made! |
It helps simplify the code and makes the kubectl plugin easier to evolve. Also fixes GoogleContainerTools#625
r2d4
approved these changes
Jun 7, 2018
|
Ah, cool – I was too tempted to improve this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It helps simplify the code and makes the kubectl plugin easier
to evolve.
Also fixes #625