Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tail false but still log issue #6299

Merged
merged 1 commit into from
Jul 27, 2021

Conversation

azhao155
Copy link
Contributor

@azhao155 azhao155 commented Jul 27, 2021

Before fix:

zyanshu@zyanshu-ubuntu:~/skaffold/examples/getting-started$ ../../out/skaffold dev  --tail=false
Listing files to watch...
 - skaffold-example
Generating tags...
 - skaffold-example -> skaffold-example:v1.28.0-31-g6713a613b
Checking cache...
 - skaffold-example: Found Locally
Starting test...
Tags used in deployment:
 - skaffold-example -> skaffold-example:4c7b5513b986043ece55e7a02d8caf636240f97c23a04153a7706ca0eeed2290
Starting deploy...
 - pod/getting-started created
Waiting for deployments to stabilize...
Deployments stabilized in 28.277599ms
Press Ctrl+C to exit
Watching for changes...
[getting-started] Hello world!
[getting-started] Hello world!
[getting-started] Hello world!
[getting-started] Hello world!
[getting-started] Hello world!

After fix:

zyanshu@zyanshu-ubuntu:~/skaffold/examples/getting-started$ ../../out/skaffold dev  --tail=false
Listing files to watch...
 - skaffold-example
Generating tags...
 - skaffold-example -> skaffold-example:v1.28.0-32-gd111965c6
Checking cache...
 - skaffold-example: Found Locally
Starting test...
Tags used in deployment:
 - skaffold-example -> skaffold-example:4c7b5513b986043ece55e7a02d8caf636240f97c23a04153a7706ca0eeed2290
Starting deploy...
 - pod/getting-started created
Waiting for deployments to stabilize...
Deployments stabilized in 33.04456ms
Press Ctrl+C to exit
Watching for changes...

fix #6216

@azhao155 azhao155 requested a review from a team as a code owner July 27, 2021 07:49
@azhao155 azhao155 requested a review from nkubala July 27, 2021 07:49
@google-cla google-cla bot added the cla: yes label Jul 27, 2021
@codecov
Copy link

codecov bot commented Jul 27, 2021

Codecov Report

Merging #6299 (d111965) into main (6713a61) will decrease coverage by 0.13%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #6299      +/-   ##
==========================================
- Coverage   70.94%   70.80%   -0.14%     
==========================================
  Files         492      494       +2     
  Lines       22240    22319      +79     
==========================================
+ Hits        15778    15803      +25     
- Misses       5445     5496      +51     
- Partials     1017     1020       +3     
Impacted Files Coverage Δ
pkg/skaffold/kubernetes/logger/log.go 32.53% <0.00%> (ø)
pkg/skaffold/util/tar.go 52.87% <0.00%> (-4.60%) ⬇️
pkg/skaffold/docker/image.go 66.55% <0.00%> (-2.33%) ⬇️
pkg/skaffold/git/gitutil.go 69.23% <0.00%> (ø)
pkg/skaffold/deploy/docker/deploy.go 0.00% <0.00%> (ø)
pkg/skaffold/docker/logger/log.go 23.07% <0.00%> (ø)
pkg/skaffold/docker/logger/formatter.go 75.00% <0.00%> (ø)
pkg/skaffold/docker/parse.go 88.23% <0.00%> (+0.84%) ⬆️
pkg/skaffold/event/v2/event.go 84.64% <0.00%> (+0.84%) ⬆️
pkg/skaffold/server/v2/endpoints.go 36.17% <0.00%> (+1.47%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6713a61...d111965. Read the comment docs.

Copy link
Contributor

@gsquared94 gsquared94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@gsquared94 gsquared94 added the kokoro:force-run forces a kokoro re-run on a PR label Jul 27, 2021
@kokoro-team kokoro-team removed the kokoro:force-run forces a kokoro re-run on a PR label Jul 27, 2021
@gsquared94 gsquared94 merged commit 96b396a into GoogleContainerTools:main Jul 27, 2021
halvards pushed a commit to halvards/skaffold that referenced this pull request Jul 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

--tail=false no longer works on dev
3 participants