Fix survey active logic #6194
Merged
Fix survey active logic #6194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #6194 +/- ##
==========================================
+ Coverage 71.08% 71.09% +0.01%
==========================================
Files 485 485
Lines 21603 21604 +1
==========================================
+ Hits 15356 15359 +3
+ Misses 5264 5263 -1
+ Partials 983 982 -1
Continue to review full report at Codecov.
|
| @@ -60,7 +60,8 @@ type config struct { | |||
| } | |||
|
|
|||
| func (s config) isActive() bool { | |||
| return s.expiresAt.IsZero() || s.expiresAt.After(time.Now()) | |||
| return s.expiresAt.IsZero() || | |||
| (s.startsAt.Before(time.Now()) && s.expiresAt.After(time.Now())) | |||
There was a problem hiding this comment.
Funny: I found this really hard to reason through — we must think of time differently!
I'd have written this as "we're after the start and before the end":
time.Now().After(s.startsAt) && time.Now().Before(s.expiresAt)
though there's a small boundary condition there that your formulation deals with 😆
briandealwis
approved these changes
Jul 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
relates to #6166
In #6185 missed the check to make sure the survey start date is in past.