Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor runID usage, populate runID field in metadata event #6033

Merged
merged 3 commits into from
Jun 18, 2021

Conversation

MarlonGamez
Copy link
Contributor

@MarlonGamez MarlonGamez commented Jun 17, 2021

Related: #5843

Description
This PR refactors the runID variable to be passed through the main RunContext of skaffold, rather than used through a package variable. It also populates the runID field in the metadata event that gets sent through the event API.

@MarlonGamez MarlonGamez requested a review from a team as a code owner June 17, 2021 19:35
@google-cla google-cla bot added the cla: yes label Jun 17, 2021
@codecov
Copy link

codecov bot commented Jun 17, 2021

Codecov Report

Merging #6033 (eb10c2f) into master (5c2e24c) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6033      +/-   ##
==========================================
- Coverage   70.77%   70.74%   -0.03%     
==========================================
  Files         462      464       +2     
  Lines       17897    17928      +31     
==========================================
+ Hits        12666    12684      +18     
- Misses       4299     4313      +14     
+ Partials      932      931       -1     
Impacted Files Coverage Δ
pkg/skaffold/deploy/label/labeller.go 68.75% <ø> (ø)
pkg/skaffold/runner/v1/new.go 64.03% <ø> (+0.17%) ⬆️
pkg/skaffold/event/v2/event.go 79.83% <100.00%> (ø)
pkg/skaffold/event/v2/metadata.go 88.73% <100.00%> (+0.16%) ⬆️
pkg/skaffold/runner/runcontext/context.go 84.50% <100.00%> (+0.33%) ⬆️
pkg/skaffold/deploy/deploy_mux.go 70.73% <0.00%> (-5.59%) ⬇️
...skaffold/kubernetes/debugging/container_manager.go 50.00% <0.00%> (-1.86%) ⬇️
pkg/skaffold/docker/parse.go 86.19% <0.00%> (-0.96%) ⬇️
pkg/skaffold/deploy/kustomize/kustomize.go 75.34% <0.00%> (-0.36%) ⬇️
pkg/skaffold/deploy/helm/deploy.go 78.92% <0.00%> (-0.25%) ⬇️
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c2e24c...eb10c2f. Read the comment docs.

@pull-request-size pull-request-size bot added size/M and removed size/S labels Jun 17, 2021
@MarlonGamez MarlonGamez changed the title Populate runID field in metadata event Refactor runID usage, populate runID field in metadata event Jun 17, 2021
@tejal29 tejal29 merged commit e01d089 into GoogleContainerTools:master Jun 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants