Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

send fully formatted output of application log through event stream #6027

Merged
merged 3 commits into from
Jun 21, 2021

Conversation

MarlonGamez
Copy link
Contributor

Related: #5368

Description
As requested by IDE teams, there will now be a field in ApplicationLogEvents that contains the fully formatted/colored output from user applications that skaffold usually outputs to stdout.

I've added a new function Sprintf for colors to use for formatting color strings.

@MarlonGamez MarlonGamez requested a review from a team as a code owner June 16, 2021 23:03
@MarlonGamez MarlonGamez requested a review from nkubala June 16, 2021 23:03
@google-cla google-cla bot added the cla: yes label Jun 16, 2021
@codecov
Copy link

codecov bot commented Jun 16, 2021

Codecov Report

Merging #6027 (dc2cfba) into master (5c2e24c) will decrease coverage by 0.03%.
The diff coverage is 30.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6027      +/-   ##
==========================================
- Coverage   70.77%   70.73%   -0.04%     
==========================================
  Files         462      464       +2     
  Lines       17897    17928      +31     
==========================================
+ Hits        12666    12682      +16     
- Misses       4299     4315      +16     
+ Partials      932      931       -1     
Impacted Files Coverage Δ
pkg/skaffold/event/v2/application_logs.go 45.45% <0.00%> (-4.55%) ⬇️
pkg/skaffold/kubernetes/logger/log.go 36.60% <0.00%> (-0.90%) ⬇️
pkg/skaffold/output/color.go 91.48% <100.00%> (+0.58%) ⬆️
pkg/skaffold/deploy/deploy_mux.go 70.73% <0.00%> (-5.59%) ⬇️
...skaffold/kubernetes/debugging/container_manager.go 50.00% <0.00%> (-1.86%) ⬇️
pkg/skaffold/docker/parse.go 86.19% <0.00%> (-0.96%) ⬇️
pkg/skaffold/deploy/kustomize/kustomize.go 75.34% <0.00%> (-0.36%) ⬇️
pkg/skaffold/deploy/helm/deploy.go 78.92% <0.00%> (-0.25%) ⬇️
pkg/skaffold/deploy/kpt/kpt.go 81.54% <0.00%> (-0.22%) ⬇️
pkg/skaffold/deploy/kubectl/kubectl.go 68.87% <0.00%> (-0.20%) ⬇️
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c2e24c...dc2cfba. Read the comment docs.

@tejal29 tejal29 merged commit 9be79bb into GoogleContainerTools:master Jun 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants