Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update hack/generate-kind-config.sh to handle multiple mirrors #5977

Merged
merged 2 commits into from
Jun 8, 2021

Conversation

briandealwis
Copy link
Member

@briandealwis briandealwis commented Jun 8, 2021

Description

Related to: #5231

Update the hack/generate-kind-config.sh to handle multiple mirrors. The containerd docs notes:

The endpoint is a list that can contain multiple image registry URLs split by commas.

The resulting output:

$ docker system info
...
Registry Mirrors:
  https://registry-1.travis-ci.com/
  https://mirror.gcr.io/
 Live Restore Enabled: false
...
apiVersion: kind.x-k8s.io/v1alpha4
kind: Cluster
containerdConfigPatches:
- |-
  [plugins."io.containerd.grpc.v1.cri".registry.mirrors."docker.io"]
    endpoint = ["https://registry-1.travis-ci.com/","https://mirror.gcr.io/"]
Creating cluster "kind" ...
 • Ensuring node image (kindest/node:v1.20.2) 🖼  ...
 ✓ Ensuring node image (kindest/node:v1.20.2) 🖼
 • Preparing nodes 📦   ...
 ✓ Preparing nodes 📦 
 • Writing configuration 📜  ...
 ✓ Writing configuration 📜
 • Starting control-plane 🕹️  ...
 ✓ Starting control-plane 🕹️
 • Installing CNI 🔌  ...
 ✓ Installing CNI 🔌
 • Installing StorageClass 💾  ...
 ✓ Installing StorageClass 💾
Set kubectl context to "kind-kind"
You can now use your cluster with:
kubectl cluster-info --context kind-kind
Thanks for using kind! 😊

@briandealwis briandealwis requested a review from a team as a code owner June 8, 2021 18:10
@briandealwis briandealwis requested a review from nkubala June 8, 2021 18:10
@google-cla google-cla bot added the cla: yes label Jun 8, 2021
@briandealwis briandealwis marked this pull request as draft June 8, 2021 18:10
@pull-request-size pull-request-size bot added size/S and removed size/XS labels Jun 8, 2021
@briandealwis
Copy link
Member Author

🎉 Hurray! Green builds from kind! 🎉

Screen Shot 2021-06-08 at 2 58 32 PM

@briandealwis briandealwis marked this pull request as ready for review June 8, 2021 18:59
Copy link
Contributor

@nkubala nkubala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎩

@codecov
Copy link

codecov bot commented Jun 8, 2021

Codecov Report

Merging #5977 (e8a37eb) into master (23098f5) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5977   +/-   ##
=======================================
  Coverage   70.67%   70.68%           
=======================================
  Files         459      459           
  Lines       17597    17659   +62     
=======================================
+ Hits        12437    12482   +45     
- Misses       4239     4253   +14     
- Partials      921      924    +3     
Impacted Files Coverage Δ
cmd/skaffold/app/cmd/inspect_profiles.go 63.15% <0.00%> (-29.15%) ⬇️
cmd/skaffold/app/cmd/inspect_modules.go 62.50% <0.00%> (-25.00%) ⬇️
pkg/skaffold/inspect/modules/list.go 83.33% <0.00%> (-16.67%) ⬇️
cmd/skaffold/app/cmd/inspect_build_env.go 58.21% <0.00%> (-1.23%) ⬇️
pkg/skaffold/parser/config.go 78.10% <0.00%> (-0.88%) ⬇️
pkg/skaffold/parser/types.go 100.00% <0.00%> (ø)
pkg/skaffold/inspect/types.go 100.00% <0.00%> (ø)
cmd/skaffold/app/cmd/inspect.go 100.00% <0.00%> (ø)
pkg/skaffold/inspect/buildEnv/list.go 100.00% <0.00%> (ø)
pkg/skaffold/schema/latest/v1/config.go 58.82% <0.00%> (ø)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23098f5...e8a37eb. Read the comment docs.

@briandealwis briandealwis merged commit 910eb4e into GoogleContainerTools:master Jun 8, 2021
@briandealwis briandealwis deleted the kind branch June 8, 2021 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants