Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid adding image digest twice to tag on render #5958

Merged
merged 1 commit into from
Jun 7, 2021

Conversation

yhrn
Copy link
Contributor

@yhrn yhrn commented Jun 7, 2021

Description

Avoid adding image digest twice to tag on render. This can happen when reading tags from file (--build-artifacts) where the tag already has a digest.

This can happen when reading tags from file (--build-artifacts) where the tag already has a digest.
@yhrn yhrn requested a review from a team as a code owner June 7, 2021 18:14
@yhrn yhrn requested a review from MarlonGamez June 7, 2021 18:14
@google-cla google-cla bot added the cla: yes label Jun 7, 2021
@codecov
Copy link

codecov bot commented Jun 7, 2021

Codecov Report

Merging #5958 (d6bc64b) into master (20e00dc) will increase coverage by 0.06%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5958      +/-   ##
==========================================
+ Coverage   70.57%   70.63%   +0.06%     
==========================================
  Files         457      458       +1     
  Lines       17534    17612      +78     
==========================================
+ Hits        12374    12441      +67     
- Misses       4246     4253       +7     
- Partials      914      918       +4     
Impacted Files Coverage Δ
pkg/skaffold/build/util.go 100.00% <100.00%> (ø)
pkg/skaffold/util/tar.go 50.66% <0.00%> (-5.34%) ⬇️
pkg/skaffold/inspect/types.go 100.00% <0.00%> (ø)
cmd/skaffold/app/cmd/inspect.go 100.00% <0.00%> (ø)
pkg/skaffold/inspect/buildEnv/modify_gcb.go 81.25% <0.00%> (ø)
pkg/skaffold/docker/parse.go 87.14% <0.00%> (+0.95%) ⬆️
cmd/skaffold/app/cmd/inspect_build_env.go 59.85% <0.00%> (+4.02%) ⬆️
pkg/skaffold/inspect/buildEnv/add_gcb.go 78.72% <0.00%> (+4.25%) ⬆️
pkg/skaffold/inspect/errors.go 56.09% <0.00%> (+56.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 20e00dc...d6bc64b. Read the comment docs.

@tejal29 tejal29 added the kokoro:run runs the kokoro jobs on a PR label Jun 7, 2021
@kokoro-team kokoro-team removed the kokoro:run runs the kokoro jobs on a PR label Jun 7, 2021
@tejal29 tejal29 enabled auto-merge (squash) June 7, 2021 20:18
@tejal29 tejal29 merged commit cbeefdc into GoogleContainerTools:master Jun 7, 2021
@yhrn yhrn deleted the fix-double-digest branch June 8, 2021 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants