Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v3] Add proto for render error code and suggestions. #5953

Merged
merged 1 commit into from
Jun 11, 2021

Conversation

yuwenma
Copy link
Contributor

@yuwenma yuwenma commented Jun 6, 2021

Fixes: #nnn
Related: #5673
Merge after: #5942

TO reviewers:
This is diff-based from #5942. Please only review the last commit

@yuwenma yuwenma requested a review from a team as a code owner June 6, 2021 01:35
@yuwenma yuwenma requested a review from aaron-prindle June 6, 2021 01:35
@google-cla google-cla bot added the cla: yes label Jun 6, 2021
@yuwenma yuwenma force-pushed the render-user-error branch from d1ff56b to 480bceb Compare June 6, 2021 01:36
@yuwenma yuwenma requested review from MarlonGamez and tejal29 and removed request for aaron-prindle June 6, 2021 01:37
@yuwenma yuwenma added this to the v1.26.0 milestone Jun 6, 2021
docs/content/en/docs/references/api/grpc.md Outdated Show resolved Hide resolved
proto/enums/enums.proto Outdated Show resolved Hide resolved
@yuwenma yuwenma force-pushed the render-user-error branch from 480bceb to ccca995 Compare June 8, 2021 05:36
@codecov
Copy link

codecov bot commented Jun 8, 2021

Codecov Report

Merging #5953 (4c20c99) into master (4bd76de) will increase coverage by 0.01%.
The diff coverage is 67.64%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5953      +/-   ##
==========================================
+ Coverage   70.69%   70.71%   +0.01%     
==========================================
  Files         459      462       +3     
  Lines       17585    17832     +247     
==========================================
+ Hits        12432    12610     +178     
- Misses       4234     4291      +57     
- Partials      919      931      +12     
Impacted Files Coverage Δ
pkg/skaffold/render/renderer/renderer.go 62.16% <47.61%> (+11.28%) ⬆️
pkg/skaffold/render/validate/validate.go 100.00% <100.00%> (ø)
cmd/skaffold/app/cmd/inspect_profiles.go 63.15% <0.00%> (-29.15%) ⬇️
cmd/skaffold/app/cmd/inspect_modules.go 62.50% <0.00%> (-25.00%) ⬇️
pkg/skaffold/kubernetes/image_list.go 76.92% <0.00%> (-23.08%) ⬇️
pkg/skaffold/kubernetes/colorpicker.go 80.00% <0.00%> (-20.00%) ⬇️
pkg/skaffold/inspect/modules/list.go 83.33% <0.00%> (-16.67%) ⬇️
pkg/skaffold/deploy/deploy_mux.go 75.67% <0.00%> (-9.18%) ⬇️
pkg/skaffold/inspect/buildEnv/add_gcb.go 71.92% <0.00%> (-6.80%) ⬇️
pkg/skaffold/kubernetes/logger/log.go 37.50% <0.00%> (-4.56%) ⬇️
... and 30 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4bd76de...4c20c99. Read the comment docs.

@yuwenma yuwenma force-pushed the render-user-error branch from ccca995 to 815f4e1 Compare June 8, 2021 17:12
@yuwenma yuwenma requested a review from tejal29 June 8, 2021 17:20
proto/enums/enums.proto Outdated Show resolved Hide resolved
proto/enums/enums.proto Outdated Show resolved Hide resolved
@yuwenma yuwenma force-pushed the render-user-error branch from 815f4e1 to eec0c5c Compare June 9, 2021 13:55
@yuwenma yuwenma requested a review from tejal29 June 9, 2021 13:57
Copy link
Contributor

@tejal29 tejal29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix nit and then submit!!

@tejal29 tejal29 removed this from the v1.26.0 milestone Jun 9, 2021
Copy link
Contributor

@tejal29 tejal29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change all references to Whitelist to allowlist

docs/content/en/docs/references/api/grpc.md Outdated Show resolved Hide resolved
docs/content/en/docs/references/api/grpc.md Outdated Show resolved Hide resolved
pkg/skaffold/render/transform/transform.go Outdated Show resolved Hide resolved
pkg/skaffold/render/transform/transform.go Outdated Show resolved Hide resolved
pkg/skaffold/render/validate/validate.go Outdated Show resolved Hide resolved
pkg/skaffold/render/validate/validate.go Outdated Show resolved Hide resolved
@yuwenma yuwenma force-pushed the render-user-error branch from eec0c5c to 0739ada Compare June 10, 2021 21:52
@yuwenma yuwenma requested a review from tejal29 June 10, 2021 21:52
@yuwenma yuwenma force-pushed the render-user-error branch from 0739ada to 4c20c99 Compare June 10, 2021 23:36
@tejal29 tejal29 added the kokoro:force-run forces a kokoro re-run on a PR label Jun 11, 2021
@kokoro-team kokoro-team removed the kokoro:force-run forces a kokoro re-run on a PR label Jun 11, 2021
@yuwenma yuwenma removed the request for review from MarlonGamez June 11, 2021 05:58
@tejal29 tejal29 merged commit 59edbda into GoogleContainerTools:master Jun 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants