Ignore first user cancelled and get actual error as final error #5941
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5424
In status check phase, when skaffold encounters the first non recoverable error, skaffold cancels the status check for all other resources and exits immediately.
We had checks in place to make sure the final error code for status check phase is the actual error that happened.
However, we did not handle the cancelled error code.
In this PR, don't return on first user cancelled error code and keep looking for the actual error code.