Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore first user cancelled and get actual error as final error #5941

Merged
merged 1 commit into from
Jun 7, 2021

Conversation

tejal29
Copy link
Contributor

@tejal29 tejal29 commented Jun 4, 2021

Fixes #5424

In status check phase, when skaffold encounters the first non recoverable error, skaffold cancels the status check for all other resources and exits immediately.
We had checks in place to make sure the final error code for status check phase is the actual error that happened.
However, we did not handle the cancelled error code.

In this PR, don't return on first user cancelled error code and keep looking for the actual error code.

@tejal29 tejal29 requested a review from a team as a code owner June 4, 2021 05:07
@tejal29 tejal29 requested a review from MarlonGamez June 4, 2021 05:07
@google-cla google-cla bot added the cla: yes label Jun 4, 2021
@codecov
Copy link

codecov bot commented Jun 4, 2021

Codecov Report

Merging #5941 (f4eb0e8) into master (aa9b115) will increase coverage by 0.00%.
The diff coverage is 85.71%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5941   +/-   ##
=======================================
  Coverage   70.66%   70.66%           
=======================================
  Files         454      454           
  Lines       17399    17401    +2     
=======================================
+ Hits        12295    12297    +2     
- Misses       4196     4197    +1     
+ Partials      908      907    -1     
Impacted Files Coverage Δ
pkg/skaffold/deploy/status/status_check.go 69.40% <85.71%> (-0.30%) ⬇️
pkg/skaffold/util/tar.go 50.66% <0.00%> (-5.34%) ⬇️
pkg/skaffold/docker/parse.go 87.14% <0.00%> (+0.95%) ⬆️
pkg/skaffold/docker/image.go 79.72% <0.00%> (+1.38%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa9b115...f4eb0e8. Read the comment docs.

Copy link
Contributor

@MarlonGamez MarlonGamez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@tejal29 tejal29 merged commit 9136544 into GoogleContainerTools:master Jun 7, 2021
@tejal29 tejal29 deleted the fix_status_check branch July 21, 2021 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Status Check misleading error
2 participants