Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kaniko: pin image version to v0.1.0 #592

Merged
merged 1 commit into from
May 25, 2018
Merged

kaniko: pin image version to v0.1.0 #592

merged 1 commit into from
May 25, 2018

Conversation

r2d4
Copy link
Contributor

@r2d4 r2d4 commented May 24, 2018

fixes #591

@r2d4
Copy link
Contributor Author

r2d4 commented May 24, 2018

I manually verified this works

@jonjohnsonjr
Copy link
Contributor

Thoughts re: pinning to a digest instead of a tag?

@dlorenc
Copy link
Contributor

dlorenc commented May 25, 2018

It's effectively the same for kaniko. We have effectively immutable tags.

@r2d4 r2d4 force-pushed the kaniko-version branch from 27a710d to 4885669 Compare May 25, 2018 03:55
@r2d4
Copy link
Contributor Author

r2d4 commented May 25, 2018

Done :)

dgageot
dgageot suggested changes May 25, 2018
View reviewed changes
Copy link
Contributor

@dgageot dgageot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick: docker pull gcr.io/kaniko-project/executor:v0.1.0@sha256:501056bf52f3a96f151ccbeb028715330d5d5aa6647e7572ce6c6c55f91ab374 is also a valid reference

@r2d4
Copy link
Contributor Author

r2d4 commented May 25, 2018

Ah thats clearer. Didn't know about that syntax.

@r2d4 r2d4 force-pushed the kaniko-version branch from 4885669 to 1435ab4 Compare May 25, 2018 05:13
@r2d4
Copy link
Contributor Author

r2d4 commented May 25, 2018

Updated

@dgageot dgageot merged commit 5371084 into GoogleContainerTools:master May 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgageot dgageot dgageot approved these changes

@dlorenc dlorenc Awaiting requested review from dlorenc

@viglesiasce viglesiasce Awaiting requested review from viglesiasce

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pin Kaniko Image tag
4 participants
@r2d4 @jonjohnsonjr @dlorenc @dgageot