Add step field for BuildSubtaskEvent to represent the different parts of a build for an artifact
#5915
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarlonGamez
changed the title
BuildSubtaskEvent to represent the different parts of a build for an artifact
Codecov Report
@@ Coverage Diff @@
## master #5915 +/- ##
==========================================
+ Coverage 70.87% 70.90% +0.03%
==========================================
Files 448 449 +1
Lines 16942 16974 +32
==========================================
+ Hits 12007 12035 +28
- Misses 4037 4040 +3
- Partials 898 899 +1
Continue to review full report at Codecov.
|
tejal29
approved these changes
Jun 1, 2021
| @@ -192,8 +192,9 @@ message BuildSubtaskEvent { | |||
| string id = 1; // id of the subtask which will be used in SkaffoldLog | |||
| string task_id = 2; // id of the task of skaffold that this event came from | |||
| string artifact = 3; // artifact name | |||
| string status = 4; // artifact build status oneof: InProgress, Completed, Failed | |||
| ActionableErr actionableErr = 5; // actionable error message | |||
| string step = 4; // which step of the build for the artifact oneof: Cache, Build, Push | |||
There was a problem hiding this comment.
Just a note: Since v2 is alpha, it is ok to change the position of the field. Usually, proto should always be backward compatible and should not change the field number.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #5423
Description
Adds a new field to
BuildSubtaskEventto represent which part of the build phase an artifact is in (ex: Build, Cache, Push). Also emits new events to represents cache checks for an artifact.User facing changes
Users will now see events to represent the cache check phase of skaffold.