Improve documentation of docker buildArgs (#5871) #5901
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fixes documentation issue where yaml syntax was not described and templating not mentioned. - Adds a unit test to verify that docker buildArgs support golang templating from the environment.
Codecov Report
@@ Coverage Diff @@
## master #5901 +/- ##
=========================================
Coverage ? 70.89%
=========================================
Files ? 448
Lines ? 16933
Branches ? 0
=========================================
Hits ? 12005
Misses ? 4034
Partials ? 894
Continue to review full report at Codecov.
|
- Fixes documentation issue where yaml syntax was not described and templating not mentioned.
- Adds a unit test to verify that docker buildArgs support golang templating from the environment.
(revised: removed a blank line in an otherwise unchanged file).
tejal29
added
the
docs-modifications
|
Please visit http://34.102.21.2:1313 to view changes to the docs. |
container-tools-bot
removed
the
docs-modifications
tejal29
approved these changes
May 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #5871
Description
This PR replaces PR-5884, which took a meandering path to get to the results you see here.
PR includes:
User facing changes (remove if N/A)
Only a change in documentation.
Change to pkg/skaffold/docker/build_args_test.go to exercise the templating code.