Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move application logs to their own endpoint for API V2 #5868

Merged

Conversation

MarlonGamez
Copy link
Contributor

Fixes: #5369

Description
Changes applicationLogEvents to have their own endpoint, rather than being put out on the event endpoint.
There are some refactors here to avoid code duplication and support future code that will be similar as well.

@MarlonGamez MarlonGamez requested a review from a team as a code owner May 19, 2021 22:03
@MarlonGamez MarlonGamez requested a review from nkubala May 19, 2021 22:03
@google-cla google-cla bot added the cla: yes label May 19, 2021
@codecov
Copy link

codecov bot commented May 19, 2021

Codecov Report

Merging #5868 (8bfb7a0) into master (540a4a0) will decrease coverage by 0.04%.
The diff coverage is 82.35%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5868      +/-   ##
==========================================
- Coverage   70.84%   70.79%   -0.05%     
==========================================
  Files         447      446       -1     
  Lines       16842    16825      -17     
==========================================
- Hits        11931    11912      -19     
+ Misses       4028     4027       -1     
- Partials      883      886       +3     
Impacted Files Coverage Δ
pkg/skaffold/server/v2/endpoints.go 42.10% <0.00%> (-1.14%) ⬇️
pkg/skaffold/event/v2/event.go 76.52% <87.50%> (-0.06%) ⬇️
pkg/skaffold/runner/v1/portforwarder.go 22.22% <0.00%> (-44.45%) ⬇️
pkg/skaffold/kubernetes/client/client.go 0.00% <0.00%> (-37.50%) ⬇️
pkg/skaffold/kubernetes/context/context.go 69.76% <0.00%> (-11.63%) ⬇️
...g/skaffold/kubernetes/portforward/pod_forwarder.go 82.00% <0.00%> (-4.28%) ⬇️
pkg/skaffold/docker/image.go 78.34% <0.00%> (-1.39%) ⬇️
pkg/skaffold/deploy/kustomize/kustomize.go 74.07% <0.00%> (-0.48%) ⬇️
pkg/skaffold/deploy/kubectl/kubectl.go 65.18% <0.00%> (-0.44%) ⬇️
pkg/skaffold/runner/v1/new.go 64.08% <0.00%> (-0.43%) ⬇️
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 540a4a0...8bfb7a0. Read the comment docs.

@tejal29 tejal29 requested review from tejal29 and removed request for nkubala May 19, 2021 23:36
@tejal29
Copy link
Contributor

tejal29 commented May 19, 2021

Assigning to myself since Nick is out this week

@tejal29 tejal29 enabled auto-merge (squash) May 19, 2021 23:39
@tejal29 tejal29 merged commit 6c57b21 into GoogleContainerTools:master May 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create an application Log event endpoint
2 participants