Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add emission of TaskEvents for Test phase #5814

Merged

Conversation

MarlonGamez
Copy link
Contributor

Related: #5422

Description
Adds emission of TaskEvents for the Test phase of skaffold

User facing changes (remove if N/A)
Users can now see TaskEvents for Test phase using the skaffold API V2

@MarlonGamez MarlonGamez requested a review from a team as a code owner May 11, 2021 18:14
@MarlonGamez MarlonGamez requested a review from aaron-prindle May 11, 2021 18:14
@google-cla google-cla bot added the cla: yes label May 11, 2021
@tejal29
Copy link
Contributor

tejal29 commented May 11, 2021

We should consider adding integration tests for V2 events and Test events

@codecov
Copy link

codecov bot commented May 11, 2021

Codecov Report

Merging #5814 (bd32c2b) into master (8efc9ef) will decrease coverage by 0.01%.
The diff coverage is 82.63%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5814      +/-   ##
==========================================
- Coverage   71.00%   70.99%   -0.02%     
==========================================
  Files         438      439       +1     
  Lines       16497    16506       +9     
==========================================
+ Hits        11714    11718       +4     
- Misses       3921     3924       +3     
- Partials      862      864       +2     
Impacted Files Coverage Δ
cmd/skaffold/app/cmd/apply.go 25.00% <0.00%> (ø)
cmd/skaffold/app/cmd/delete.go 57.14% <0.00%> (ø)
cmd/skaffold/app/cmd/deploy.go 56.52% <0.00%> (ø)
cmd/skaffold/app/cmd/filter.go 25.58% <0.00%> (ø)
cmd/skaffold/app/cmd/find_configs.go 48.48% <0.00%> (ø)
cmd/skaffold/app/cmd/generate_pipeline.go 61.53% <0.00%> (ø)
cmd/skaffold/app/cmd/render.go 40.74% <0.00%> (ø)
cmd/skaffold/app/cmd/runner.go 58.49% <0.00%> (ø)
cmd/skaffold/app/cmd/test.go 46.66% <0.00%> (ø)
cmd/skaffold/app/cmd/util.go 77.77% <ø> (ø)
... and 133 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d05e94...bd32c2b. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants