[V3] add renderer basic struct. #5793
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuwenma
requested review from
tejal29
and removed request for
briandealwis and
tejal29
Codecov Report
@@ Coverage Diff @@
## master #5793 +/- ##
==========================================
- Coverage 70.90% 70.88% -0.02%
==========================================
Files 447 448 +1
Lines 16908 16932 +24
==========================================
+ Hits 11988 12002 +14
- Misses 4029 4034 +5
- Partials 891 896 +5
Continue to review full report at Codecov.
|
yuwenma
force-pushed
the
render-1-basic
branch
2 times, most recently
from
5cd8c68 to
41093fd
Compare
The renderer struct initialize generator which parses the DRY config and stores the dry config in a tmp directory.
tejal29
approved these changes
May 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #nnn
Related: #5673
Merge after: #5865
Description
The renderer struct initialize generator which parses the DRY config and stores the dry config in a tmp directory.
To reviewers:
this PR is diff-based from #5865, to review the renderer specific code change, please see this
4867900(#5793)