Resolve all filepaths to absolute in 'skaffold diagnose' #5791
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
this change forces absolute path resolution for all paths provided in a
skaffold.yaml
when runningskaffold diagnose
.User facing changes (remove if N/A)
paths provided in a
skaffold.yaml
will now always be resolved to absolute.given our
getting-started
example:Before:
After:
the purpose of
skaffold diagnose
is to inspect exactly what skaffold is doing at runtime - this change makes which files skaffold is using more clear. additionally, this makes the output ofskaffold diagnose --yaml-only
more useful in successive skaffold runs outside of the root directory (specifically, providing it toskaffold render
).