Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emit TaskEvent protos for Test phase #5786

Merged
merged 1 commit into from
May 4, 2021

Conversation

MarlonGamez
Copy link
Contributor

Related: #5368

Description
Emits task event protos for test phase

Follow up work
Emit test subtask event protos

@MarlonGamez MarlonGamez requested a review from a team as a code owner May 4, 2021 21:46
@MarlonGamez MarlonGamez requested a review from aaron-prindle May 4, 2021 21:46
@google-cla google-cla bot added the cla: yes label May 4, 2021
@MarlonGamez MarlonGamez changed the title linters Emit TaskEvent protos for Test phase May 4, 2021
Copy link
Contributor

@aaron-prindle aaron-prindle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented May 4, 2021

Codecov Report

Merging #5786 (0040ce0) into master (d14f34d) will decrease coverage by 0.04%.
The diff coverage is 47.22%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5786      +/-   ##
==========================================
- Coverage   70.78%   70.73%   -0.05%     
==========================================
  Files         432      433       +1     
  Lines       16242    16273      +31     
==========================================
+ Hits        11497    11511      +14     
- Misses       3901     3912      +11     
- Partials      844      850       +6     
Impacted Files Coverage Δ
cmd/skaffold/skaffold.go 0.00% <0.00%> (ø)
pkg/skaffold/build/jib/init.go 83.05% <0.00%> (-4.45%) ⬇️
pkg/skaffold/build/jib/jib.go 69.46% <0.00%> (-1.08%) ⬇️
pkg/skaffold/util/tar.go 56.00% <0.00%> (+5.33%) ⬆️
cmd/skaffold/app/cmd/cmd.go 63.80% <50.00%> (ø)
pkg/skaffold/color/formatter.go 96.00% <50.00%> (-4.00%) ⬇️
pkg/skaffold/build/jib/jvm.go 55.55% <55.55%> (ø)
pkg/skaffold/util/term.go 52.94% <60.00%> (+10.08%) ⬆️
pkg/skaffold/runner/tester.go 100.00% <100.00%> (ø)
pkg/skaffold/docker/image.go 78.34% <0.00%> (-1.39%) ⬇️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a9a18d8...0040ce0. Read the comment docs.

@MarlonGamez MarlonGamez merged commit efd6c5b into GoogleContainerTools:master May 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants