-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add skaffold inspect
command
#5765
Add skaffold inspect
command
#5765
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5765 +/- ##
==========================================
- Coverage 70.87% 70.76% -0.11%
==========================================
Files 421 432 +11
Lines 16087 16242 +155
==========================================
+ Hits 11401 11494 +93
- Misses 3850 3902 +52
- Partials 836 846 +10
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code looks good! just have a questions about organization
limitations under the License. | ||
*/ | ||
|
||
package cmd |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we want to move this into a subpackage? A bit worried that we may clutter up the cmd/
dir even more with these subcommands
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I took a stab at it but it's very convoluted the way command builder
, command definitions
and command instantiations
interact along with common and specific flags
instantiations. I'll look at that separate from this PR.
Related: #5758
Description
skaffold inspect
skaffold inspect modules list