Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add skaffold inspect command #5765

Merged
merged 2 commits into from
May 3, 2021

Conversation

gsquared94
Copy link
Contributor

Related: #5758

Description

  • Adds command skaffold inspect
  • Implements skaffold inspect modules list

@codecov
Copy link

codecov bot commented Apr 30, 2021

Codecov Report

Merging #5765 (b2e078e) into master (4106c53) will decrease coverage by 0.10%.
The diff coverage is 97.87%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5765      +/-   ##
==========================================
- Coverage   70.87%   70.76%   -0.11%     
==========================================
  Files         421      432      +11     
  Lines       16087    16242     +155     
==========================================
+ Hits        11401    11494      +93     
- Misses       3850     3902      +52     
- Partials      836      846      +10     
Impacted Files Coverage Δ
cmd/skaffold/app/cmd/inspect_modules.go 87.50% <87.50%> (ø)
cmd/skaffold/app/cmd/cmd.go 63.80% <100.00%> (+0.22%) ⬆️
cmd/skaffold/app/cmd/commands.go 81.63% <100.00%> (+1.63%) ⬆️
cmd/skaffold/app/cmd/config.go 100.00% <100.00%> (ø)
cmd/skaffold/app/cmd/inspect.go 100.00% <100.00%> (ø)
pkg/skaffold/inspect/modules.go 100.00% <100.00%> (ø)
pkg/skaffold/inspect/output.go 100.00% <100.00%> (ø)
pkg/skaffold/parser/config.go 79.68% <100.00%> (+0.99%) ⬆️
pkg/skaffold/util/tar.go 50.66% <0.00%> (-5.34%) ⬇️
cmd/skaffold/app/cmd/render.go 44.44% <0.00%> (-1.99%) ⬇️
... and 28 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4106c53...b2e078e. Read the comment docs.

Copy link
Contributor

@MarlonGamez MarlonGamez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks good! just have a questions about organization

limitations under the License.
*/

package cmd
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we want to move this into a subpackage? A bit worried that we may clutter up the cmd/ dir even more with these subcommands

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I took a stab at it but it's very convoluted the way command builder, command definitions and command instantiations interact along with common and specific flags instantiations. I'll look at that separate from this PR.

@gsquared94 gsquared94 marked this pull request as ready for review May 3, 2021 19:04
@gsquared94 gsquared94 requested a review from a team as a code owner May 3, 2021 19:04
@gsquared94 gsquared94 merged commit d14f34d into GoogleContainerTools:master May 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants