-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bring back error coloring #5718
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5718 +/- ##
==========================================
- Coverage 70.87% 70.74% -0.13%
==========================================
Files 421 433 +12
Lines 16087 16270 +183
==========================================
+ Hits 11401 11511 +110
- Misses 3850 3911 +61
- Partials 836 848 +12
Continue to review full report at Codecov.
|
briandealwis
reviewed
May 3, 2021
briandealwis
approved these changes
May 3, 2021
tejal29
reviewed
May 3, 2021
Co-authored-by: Brian de Alwis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #5643
Description
Coloring on our error output has been broken since we made changes to validating color output a while ago. This change reintroduces red coloring on errors from skaffold. I've also added more validation for color, as some terminals don't support colors.
User facing changes (remove if N/A)
Users should now see errors in red when running skaffold