Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bring back error coloring #5718

Merged
merged 9 commits into from
May 4, 2021

Conversation

MarlonGamez
Copy link
Contributor

Fixes: #5643
Description
Coloring on our error output has been broken since we made changes to validating color output a while ago. This change reintroduces red coloring on errors from skaffold. I've also added more validation for color, as some terminals don't support colors.

User facing changes (remove if N/A)
Users should now see errors in red when running skaffold

@MarlonGamez MarlonGamez requested a review from a team as a code owner April 22, 2021 22:40
@google-cla google-cla bot added the cla: yes label Apr 22, 2021
@codecov
Copy link

codecov bot commented Apr 23, 2021

Codecov Report

Merging #5718 (877ae79) into master (d38ab4d) will decrease coverage by 0.12%.
The diff coverage is 47.36%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5718      +/-   ##
==========================================
- Coverage   70.87%   70.74%   -0.13%     
==========================================
  Files         421      433      +12     
  Lines       16087    16270     +183     
==========================================
+ Hits        11401    11511     +110     
- Misses       3850     3911      +61     
- Partials      836      848      +12     
Impacted Files Coverage Δ
cmd/skaffold/skaffold.go 0.00% <0.00%> (ø)
pkg/skaffold/util/tar.go 56.00% <0.00%> (ø)
cmd/skaffold/app/cmd/cmd.go 63.80% <50.00%> (+0.22%) ⬆️
pkg/skaffold/color/formatter.go 96.00% <50.00%> (-4.00%) ⬇️
pkg/skaffold/util/term.go 52.94% <60.00%> (+10.08%) ⬆️
pkg/skaffold/build/jib/init.go 83.05% <0.00%> (-4.45%) ⬇️
cmd/skaffold/app/cmd/render.go 44.44% <0.00%> (-1.99%) ⬇️
cmd/skaffold/app/cmd/runner.go 58.49% <0.00%> (-1.51%) ⬇️
pkg/skaffold/build/jib/jib.go 69.46% <0.00%> (-1.08%) ⬇️
pkg/skaffold/runner/deploy.go 53.00% <0.00%> (-0.61%) ⬇️
... and 30 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d38ab4d...877ae79. Read the comment docs.

@pull-request-size pull-request-size bot added size/M and removed size/L labels Apr 23, 2021
cmd/skaffold/skaffold.go Show resolved Hide resolved
pkg/skaffold/util/term.go Outdated Show resolved Hide resolved
@pull-request-size pull-request-size bot added size/L and removed size/M labels Apr 26, 2021
pkg/skaffold/util/term.go Outdated Show resolved Hide resolved
pkg/skaffold/util/term.go Outdated Show resolved Hide resolved
@MarlonGamez MarlonGamez merged commit a9a18d8 into GoogleContainerTools:master May 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Colorize Skaffold actionable error messages
3 participants