Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve multi-config documentation #5714

Merged
merged 4 commits into from
Apr 22, 2021
Merged

Improve multi-config documentation #5714

merged 4 commits into from
Apr 22, 2021

Conversation

gsquared94
Copy link
Contributor

No description provided.

@gsquared94 gsquared94 requested a review from a team as a code owner April 21, 2021 20:00
@google-cla google-cla bot added the cla: yes label Apr 21, 2021
@gsquared94 gsquared94 added the docs-modifications runs the docs preview service on the given PR label Apr 21, 2021
@container-tools-bot container-tools-bot removed the docs-modifications runs the docs preview service on the given PR label Apr 21, 2021
@gsquared94
Copy link
Contributor Author

http://35.236.46.78:1313/docs/design/config/#multiple-configuration-support

viglesiasce
viglesiasce previously requested changes Apr 21, 2021
View reviewed changes
Copy link
Contributor

@viglesiasce viglesiasce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall the info is good but i think at this point we need to bite off explicitly calling things modules. That is what the flag is and it will be easier to change the docs than the flag i believe.

@gsquared94 gsquared94 added the docs-modifications runs the docs preview service on the given PR label Apr 21, 2021
@container-tools-bot container-tools-bot removed the docs-modifications runs the docs preview service on the given PR label Apr 21, 2021
@codecov
Copy link

codecov bot commented Apr 21, 2021 •
edited
Loading

Codecov Report

Merging #5714 (7b8069a) into master (46d1c2f) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5714      +/-   ##
==========================================
- Coverage   70.53%   70.51%   -0.02%     
==========================================
  Files         413      413              
  Lines       15982    15982              
==========================================
- Hits        11273    11270       -3     
- Misses       3879     3880       +1     
- Partials      830      832       +2
Impacted Files Coverage Δ
pkg/skaffold/docker/image.go 78.34% <0.00%> (-1.39%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 46d1c2f...7b8069a. Read the comment docs.

@gsquared94 gsquared94 added the docs-modifications runs the docs preview service on the given PR label Apr 21, 2021
@container-tools-bot
Copy link

Please visit http://35.236.46.78:1313 to view changes to the docs.

@container-tools-bot container-tools-bot removed the docs-modifications runs the docs preview service on the given PR label Apr 21, 2021
@gsquared94 gsquared94 requested a review from viglesiasce April 22, 2021 01:16
@gsquared94 gsquared94 dismissed viglesiasce’s stale review April 22, 2021 18:47

Incorporated suggestions.

@gsquared94 gsquared94 merged commit b30b60c into GoogleContainerTools:master Apr 22, 2021
gsquared94 added a commit that referenced this pull request Apr 22, 2021
@gsquared94
Improve multi-config documentation (#5714)
6c517ae 
* Improve multi-config documentation

* define module

* use full flag name

* more rename
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tejal29 tejal29 tejal29 approved these changes

@viglesiasce viglesiasce Awaiting requested review from viglesiasce

Assignees
No one assigned
Labels
cla: yes size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gsquared94 @container-tools-bot @viglesiasce @tejal29