[WIP] Add a label to the deployments #569
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgageot
force-pushed
the
add-label
branch
5 times, most recently
from
a841140
to
742a674
Compare
dgageot
force-pushed
the
add-label
branch
3 times, most recently
from
386f30f
to
e5402bc
Compare
Signed-off-by: David Gageot <[email protected]>
|
I'm trying to decide if I close this one or carry on |
|
@dgageot I'm working on labeling all k8s deployments coming from skaffold right now, including ones deployed with helm. I can take this over from you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a
skaffold:truelabel to what's deployed by thekubectldeployer.We might want to apply additional or different labels.