Add taskevents Test, StatusCheck, and fix duplicates for Deploy #5675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5675 +/- ##
==========================================
+ Coverage 70.63% 70.66% +0.02%
==========================================
Files 411 411
Lines 15777 15795 +18
==========================================
+ Hits 11144 11161 +17
- Misses 3812 3813 +1
Partials 821 821
Continue to review full report at Codecov.
|
tejal29
approved these changes
Apr 14, 2021
tejal29
approved these changes
Apr 14, 2021
| if err := r.tester.Test(ctx, out, artifacts); err != nil { | ||
| eventV2.TaskFailed(constants.Test, r.devIteration, err) |
There was a problem hiding this comment.
Note: This will not add event per tester right? We can add those later in a separate PR.
There was a problem hiding this comment.
Yup, this is just for the over arching test phase
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #5368 #5422
Description
Adds emission of TaskEvent protos for Test and StatusCheck phases. Also fixes duplicate emission of Deploy TaskEvents
User facing changes (remove if N/A)
User will now see TaskEvents for phases mentioned
Follow-up Work (remove if N/A)
Add emission for PortForwarding