Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added helm remote repo example #5640

Merged
merged 10 commits into from
Apr 7, 2021
Merged

Added helm remote repo example #5640

merged 10 commits into from
Apr 7, 2021

Conversation

dhodun
Copy link
Contributor

@dhodun dhodun commented Apr 7, 2021

Fixes: #5517
Added helm remote repo example, per @gsquared94

@dhodun dhodun requested a review from a team as a code owner April 7, 2021 19:49
@google-cla google-cla bot added the cla: yes label Apr 7, 2021
@codecov
Copy link

codecov bot commented Apr 7, 2021

Codecov Report

Merging #5640 (03deae4) into master (fd96d77) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5640      +/-   ##
==========================================
- Coverage   70.68%   70.67%   -0.02%     
==========================================
  Files         408      408              
  Lines       15581    15581              
==========================================
- Hits        11014    11012       -2     
- Misses       3757     3758       +1     
- Partials      810      811       +1     
Impacted Files Coverage Δ
pkg/skaffold/util/tar.go 50.66% <0.00%> (-5.34%) ⬇️
pkg/skaffold/docker/parse.go 85.40% <0.00%> (+1.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd96d77...03deae4. Read the comment docs.

@gsquared94 gsquared94 added the kokoro:force-run forces a kokoro re-run on a PR label Apr 7, 2021
@kokoro-team kokoro-team removed the kokoro:force-run forces a kokoro re-run on a PR label Apr 7, 2021
@gsquared94 gsquared94 merged commit 4866153 into GoogleContainerTools:master Apr 7, 2021
@bouckj
Copy link

bouckj commented Mar 31, 2022

Is there any documentation for how to add authentication to a remote Helm repo?

For instance, using a private GitHub repo as a Helm repo I need to provide my GitHub access token when adding the Helm repo if I do it manually:

helm repo add example-repo --username "<GITHUB_USERNAME>" --password "<GITHUB_ACCESS_TOKEN>" 'https://raw.githubusercontent.com/my/helm/repo/'

I don't see how to instruct Skaffold to add the username and password when using the 'repo' and 'remoteChart' options. I see there's a 'useHelmSecrets' config option, but can't find a single example using it anywhere similar to my case.

@briandealwis
Copy link
Member

@bouckj There is no support for adding Helm repositories on-the-fly though there has been a little bit of discussion on #2653. For now you would need to do this outside of Skaffold.

Perhaps you could sketch how you add the repository currently on #2653 and describe how you retrieve the username and password secret?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add remote helm chart example
5 participants