Add event API v2 server handler #5622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5622 +/- ##
==========================================
- Coverage 70.79% 70.68% -0.12%
==========================================
Files 406 407 +1
Lines 15461 15554 +93
==========================================
+ Hits 10946 10994 +48
- Misses 3711 3752 +41
- Partials 804 808 +4
Continue to review full report at Codecov.
|
|
Still need to add tests, but putting this up here in case anyone wants to take a look :) |
tejal29
approved these changes
Apr 2, 2021
| @@ -190,6 +241,19 @@ func emptyStatusCheckState() *proto.StatusCheckState { | |||
| } | |||
| } | |||
|
|
|||
| func AutoTriggerDiff(name string, val bool) (bool, error) { | |||
| switch name { | |||
| case "build": | |||
There was a problem hiding this comment.
we could reuse pkg/errors.Phase type and add sync to it?
There was a problem hiding this comment.
Good point! I'll update this in a follow up
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #5422 , #5368
Description
Adds
pkg/skaffold/server/v2package which contains a new struct that handles the endpoints for the v2 API. Users will now be able to hit both the v1 and v2 endpoints through the running gRPC server.Most of the server definition is copied from
pkg/skaffold/serverfiles, and the functions added topkg/skaffold/event/v2/event.goare straight frompkg/skaffold/event/event.goFollow-up Work (remove if N/A)
Emit protos on this server