-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding events for Test phase #5573
Adding events for Test phase #5573
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5573 +/- ##
==========================================
+ Coverage 71.05% 71.08% +0.03%
==========================================
Files 402 402
Lines 15096 15145 +49
==========================================
+ Hits 10726 10766 +40
- Misses 3577 3586 +9
Partials 793 793
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please address the review comments. Otherwise changes look good.
Addresses the feedback. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
Fixes: #5539
Description
Adding events for Test phase
Skaffold currently doesn't log events for test phase progress.
With this change the tests log test progress events .
Related:
#5333
Example
The functionality can be tested using the example in the integration tests:
skaffold/integration/examples/test-events-test