Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding events for Test phase #5573

Merged
merged 19 commits into from
Mar 22, 2021

Conversation

PriyaModali
Copy link
Contributor

@PriyaModali PriyaModali commented Mar 18, 2021

Fixes: #5539

Description
Adding events for Test phase

Skaffold currently doesn't log events for test phase progress.
With this change the tests log test progress events .

Related:
#5333

Example

The functionality can be tested using the example in the integration tests:
skaffold/integration/examples/test-events-test

@PriyaModali PriyaModali added kind/feature-request area/testing Issues concerning the testing phase of Skaffold priority/p1 High impact feature/bug. labels Mar 18, 2021
@google-cla google-cla bot added the cla: yes label Mar 18, 2021
@codecov
Copy link

codecov bot commented Mar 18, 2021

Codecov Report

Merging #5573 (04ab4fa) into master (e74d752) will increase coverage by 0.03%.
The diff coverage is 90.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5573      +/-   ##
==========================================
+ Coverage   71.05%   71.08%   +0.03%     
==========================================
  Files         402      402              
  Lines       15096    15145      +49     
==========================================
+ Hits        10726    10766      +40     
- Misses       3577     3586       +9     
  Partials      793      793              
Impacted Files Coverage Δ
pkg/skaffold/errors/errors.go 91.48% <ø> (+2.12%) ⬆️
pkg/skaffold/instrumentation/export.go 75.55% <0.00%> (-1.72%) ⬇️
pkg/skaffold/event/event.go 91.06% <94.44%> (-0.42%) ⬇️
pkg/skaffold/runner/dev.go 72.22% <100.00%> (+0.17%) ⬆️
pkg/skaffold/test/custom/custom.go 58.94% <100.00%> (+2.76%) ⬆️
pkg/skaffold/test/structure/structure.go 88.13% <100.00%> (+0.63%) ⬆️
pkg/skaffold/util/tar.go 50.66% <0.00%> (-5.34%) ⬇️
pkg/skaffold/docker/parse.go 85.40% <0.00%> (+1.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e74d752...04ab4fa. Read the comment docs.

@PriyaModali PriyaModali marked this pull request as ready for review March 19, 2021 03:29
@PriyaModali PriyaModali requested a review from a team as a code owner March 19, 2021 03:29
Copy link
Contributor

@gsquared94 gsquared94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address the review comments. Otherwise changes look good.

@PriyaModali
Copy link
Contributor Author

Please address the review comments. Otherwise changes look good.

Addresses the feedback.

@PriyaModali PriyaModali dismissed gsquared94’s stale review March 20, 2021 01:54

Addresses the feedback.

Copy link
Contributor

@gsquared94 gsquared94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@gsquared94 gsquared94 merged commit 70cd58b into GoogleContainerTools:master Mar 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/testing Issues concerning the testing phase of Skaffold cla: yes kind/feature-request priority/p1 High impact feature/bug. size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add events for Test phase to support re-executing tests
2 participants