Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give v2 proto different package name #5557

Merged
merged 1 commit into from
Mar 17, 2021

Conversation

MarlonGamez
Copy link
Contributor

Related: #5368

Description
Gives the v2 proto package a new name. This is to prevent issues that arise from both v1 and v2 trying to register protos with the same name in the same package

@MarlonGamez MarlonGamez requested a review from a team as a code owner March 16, 2021 23:08
@google-cla google-cla bot added the cla: yes label Mar 16, 2021
@codecov
Copy link

codecov bot commented Mar 16, 2021

Codecov Report

Merging #5557 (0039b13) into master (116201a) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5557      +/-   ##
==========================================
+ Coverage   71.28%   71.30%   +0.02%     
==========================================
  Files         400      400              
  Lines       14971    14987      +16     
==========================================
+ Hits        10672    10687      +15     
+ Misses       3512     3510       -2     
- Partials      787      790       +3     
Impacted Files Coverage Δ
pkg/skaffold/docker/image.go 78.13% <0.00%> (-1.40%) ⬇️
pkg/skaffold/instrumentation/export.go 77.27% <0.00%> (-0.18%) ⬇️
cmd/skaffold/app/cmd/build.go 89.74% <0.00%> (ø)
cmd/skaffold/app/cmd/version.go 85.71% <0.00%> (ø)
pkg/skaffold/runner/changeset.go 77.77% <0.00%> (ø)
pkg/skaffold/runner/timings.go 95.34% <0.00%> (+0.22%) ⬆️
pkg/skaffold/runner/dev.go 72.04% <0.00%> (+0.52%) ⬆️
pkg/skaffold/event/event.go 91.47% <0.00%> (+0.69%) ⬆️
cmd/skaffold/app/cmd/flags.go 88.88% <0.00%> (+0.95%) ⬆️
pkg/skaffold/errors/errors.go 89.36% <0.00%> (+2.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 116201a...0039b13. Read the comment docs.

Copy link
Contributor

@nkubala nkubala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one comment

hack/generate-proto.sh Outdated Show resolved Hide resolved
@nkubala nkubala merged commit 0fe5fd4 into GoogleContainerTools:master Mar 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants