Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation for Custom Test in Skaffold #5521

Merged
merged 4 commits into from
Mar 10, 2021

Conversation

PriyaModali
Copy link
Contributor

@PriyaModali PriyaModali commented Mar 10, 2021

Fixes: ##5520
Description
Adding documentation for the newly implemented Custom Test feature.

  • Created a new directory for Test
  • Migrated existing Test doc page to Container Structure Test and moved it under Test directory
  • Added a new doc page for Custom Test with all the relevant content and examples
  • Added new samples for Custom Test
  • Added references to Test at relevant places in the Skaffold doc site
  • Updated all the relevant links and paths to support the newly added content
  • Added Test to the info panel on the right
  • Added maturity level alpha to the newly added Custom Test feature

User facing changes
Three new pages are added to the Skaffold documentation:

Related:
#5333

@google-cla google-cla bot added the cla: yes label Mar 10, 2021
@PriyaModali PriyaModali added area/testing Issues concerning the testing phase of Skaffold kind/documentation priority/p1 High impact feature/bug. docs-modifications runs the docs preview service on the given PR labels Mar 10, 2021
@container-tools-bot
Copy link

Please visit http://35.236.47.144:1313 to view changes to the docs.

@container-tools-bot container-tools-bot removed the docs-modifications runs the docs preview service on the given PR label Mar 10, 2021
@codecov
Copy link

codecov bot commented Mar 10, 2021

Codecov Report

Merging #5521 (c189b4b) into master (3160270) will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5521      +/-   ##
==========================================
+ Coverage   71.32%   71.35%   +0.03%     
==========================================
  Files         400      400              
  Lines       14831    14831              
==========================================
+ Hits        10578    10583       +5     
+ Misses       3475     3473       -2     
+ Partials      778      775       -3     
Impacted Files Coverage Δ
pkg/skaffold/docker/parse.go 82.16% <0.00%> (-1.09%) ⬇️
pkg/skaffold/docker/image.go 79.53% <0.00%> (+1.39%) ⬆️
pkg/skaffold/util/tar.go 56.00% <0.00%> (+5.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3160270...c189b4b. Read the comment docs.

@PriyaModali PriyaModali changed the title Adding Custom Test to the Skaffold documentation. Documentation for Custom Test in Skaffold Mar 10, 2021
@PriyaModali PriyaModali marked this pull request as ready for review March 10, 2021 16:41
@PriyaModali PriyaModali requested a review from a team as a code owner March 10, 2021 16:41
@gsquared94 gsquared94 added the docs-modifications runs the docs preview service on the given PR label Mar 10, 2021
@container-tools-bot
Copy link

Please visit http://35.236.47.144:1313 to view changes to the docs.

@container-tools-bot container-tools-bot removed the docs-modifications runs the docs preview service on the given PR label Mar 10, 2021
@PriyaModali PriyaModali merged commit 64d3821 into GoogleContainerTools:master Mar 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/testing Issues concerning the testing phase of Skaffold cla: yes kind/documentation priority/p1 High impact feature/bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants