fix: Parsing fails for named multistage dockerfile using build artifact dependency #5507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5507 +/- ##
==========================================
+ Coverage 71.41% 71.49% +0.07%
==========================================
Files 398 398
Lines 14654 14641 -13
==========================================
+ Hits 10465 10467 +2
+ Misses 3410 3400 -10
+ Partials 779 774 -5
Continue to review full report at Codecov.
|
gsquared94
commented
Mar 10, 2021
| // Stage names are case insensitive | ||
| stages[strings.ToLower(from.as)] = true | ||
| } | ||
|
|
||
| if from.image == "" { | ||
| // some build args like artifact dependencies are not available until the first build sequence has completed. | ||
| // skip check if there are unavailable images | ||
| continue |
There was a problem hiding this comment.
immediately continuing with the next iteration was wrong here; we need to save the instruction's AS value also to stages map.
nkubala
approved these changes
Mar 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #5498