Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding distinct error codes for custom test failures #5501

Merged
merged 10 commits into from
Mar 10, 2021
Merged

Adding distinct error codes for custom test failures #5501

merged 10 commits into from
Mar 10, 2021

Conversation

PriyaModali
Copy link
Contributor

@PriyaModali PriyaModali commented Mar 6, 2021 •
edited
Loading

Fixes: #5431

Description
Adding error codes for custom test failures

User facing changes
These changes will enable Skaffold dev to return distinct error codes when custom tests fail.

There are no visible user facing changes.

Related:
#5333

@PriyaModali PriyaModali added kind/feature-request area/testing Issues concerning the testing phase of Skaffold priority/p1 High impact feature/bug. labels Mar 6, 2021
@PriyaModali PriyaModali requested a review from a team as a code owner March 6, 2021 18:55
@google-cla google-cla bot added the cla: yes label Mar 6, 2021
@codecov
Copy link

codecov bot commented Mar 6, 2021 •
edited
Loading

Codecov Report

Merging #5501 (f6850b5) into master (802ef8a) will decrease coverage by 0.35%.
The diff coverage is 8.98%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5501      +/-   ##
==========================================
- Coverage   71.70%   71.35%   -0.36%     
==========================================
  Files         399      400       +1     
  Lines       14750    14831      +81     
==========================================
+ Hits        10577    10583       +6     
- Misses       3398     3473      +75     
  Partials      775      775
Impacted Files Coverage Δ
pkg/skaffold/test/custom/error.go 7.59% <7.59%> (ø)
pkg/skaffold/test/custom/custom.go 56.45% <20.00%> (-1.89%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 802ef8a...f6850b5. Read the comment docs.

gsquared94
gsquared94 reviewed Mar 9, 2021
View reviewed changes
proto/v1/skaffold.proto Outdated Show resolved Hide resolved
gsquared94
gsquared94 reviewed Mar 9, 2021
View reviewed changes
proto/enums/enums.proto Outdated Show resolved Hide resolved
gsquared94
gsquared94 approved these changes Mar 10, 2021
View reviewed changes
Copy link
Contributor

@gsquared94 gsquared94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@PriyaModali PriyaModali merged commit 3160270 into GoogleContainerTools:master Mar 10, 2021
@PriyaModali PriyaModali mentioned this pull request Mar 12, 2021
Closed
10 tasks
@gofish-bot gofish-bot mentioned this pull request Mar 19, 2021
Merged
@PriyaModali PriyaModali mentioned this pull request Mar 21, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gsquared94 gsquared94 gsquared94 approved these changes

Assignees
No one assigned
Labels
area/testing Issues concerning the testing phase of Skaffold cla: yes kind/feature-request priority/p1 High impact feature/bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add distinct error codes for custom test failures
2 participants
@PriyaModali @gsquared94