-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix custom build example #5495
Fix custom build example #5495
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5495 +/- ##
=======================================
Coverage 71.42% 71.42%
=======================================
Files 398 398
Lines 14654 14654
=======================================
Hits 10467 10467
Misses 3409 3409
Partials 778 778 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, tested locally and seems to work. I think we may have an issue with a code path not being hit. Left a comment on the linked issue
This isn't right: Skaffold has special treatment for |
This example was broken as the |
Fixes: #5492
Description
Make custom build example functional
Custom build example is currently broken. It needs to be fixed.
User facing changes
Before:
After: