fix logic that set absolute paths in the parsed configuration

[gsquared94]

Fixes: #5396

Test

Setup the files

├── frontend
│   └── web-app
│       └── skaffold.yaml
└── skaffold.yaml

where:
/skaffold.yaml:

apiVersion: skaffold/v2beta12
kind: Config
metadata:
  name: hikingo

requires:
- path: ./frontend/web-app

frontend/web-app/skaffold.yaml:

apiVersion: skaffold/v2beta12
kind: Config
metadata:
  name: web-app
build:
  artifacts:
  - image: xyz
deploy:
  helm:
    releases:
    - name: web-app
      chartPath: ../../infra/charts/microservice
      artifactOverrides:
        image: xyz
      valuesFiles:
      - ./helm-values.yaml

From root directory run:

skaffold diagnose --yaml-only

Before fix Output

...
deploy:
  helm:
    releases:
    - name: web-app
      chartPath: /Users/gaghosh/Code/Hack/repro-5396/infra/charts/microservice
      valuesFiles:
      - ./helm-values.yaml      // <==== failed to set absolute path here
...

After fix Output

...
deploy:
  helm:
    releases:
    - name: web-app
      chartPath: /Users/gaghosh/Code/Hack/repro-5396/infra/charts/microservice
      valuesFiles:
      - /Users/gaghosh/Code/Hack/repro-5396/frontend/web-app/helm-values.yaml
...

[codecov]

Codecov Report

Merging #5452 (e7405a4) into master (7f2eeed) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #5452   +/-   ##
=======================================
  Coverage   71.41%   71.42%           
=======================================
  Files         397      397           
  Lines       14551    14547    -4     
=======================================
- Hits        10392    10390    -2     
+ Misses       3388     3387    -1     
+ Partials      771      770    -1     

Impacted Files	Coverage Δ
pkg/skaffold/tags/paths.go	73.21% <100.00%> (+1.54%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f2eeed...e7405a4. Read the comment docs.

[gsquared94]

was erroneously returning here. That meant if two successive fields in a struct have the filepath tag (like HelmRelease) and the first is set to an absolute value already, then the second field did not get processed.

[MarlonGamez]

LGTM 👍🏼

[ReneWerner87]

@gsquared94 what about the other helm configuration options ? like the setFiles part?
https://skaffold.dev/docs/references/yaml/#deploy-helm-releases-setFiles
the problem still exists there

By the way, the feature with the multi repos is mega cool(thx for the effort), wanted to use it, but this issue and the part with the setFiles are blocking me.