Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add golint support for M1 macs (darwin/arm64 arch) #5435

Merged

Conversation

ricardo-larosa
Copy link
Contributor

Fixes: #5434

Description

  • Bump golint version to 1.37.1 which now supports darwin/arm64 arch
  • Add darwin/arm64 to hack/install_golint.sh
  • Fix golint/gocritic issues (spaces, use of ReplaceAll)
  • Fix shadowing of defer os.Exit(0) in cmd_test.go

@google-cla google-cla bot added the cla: yes label Feb 22, 2021
@ricardo-larosa ricardo-larosa changed the title Add support of Golint on M1 macs (darwin/arm64 arch) Add golint support for M1 macs (darwin/arm64 arch) Feb 22, 2021
@codecov
Copy link

codecov bot commented Feb 22, 2021

Codecov Report

Merging #5435 (60b3f7d) into master (4588f51) will decrease coverage by 0.02%.
The diff coverage is 85.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5435      +/-   ##
==========================================
- Coverage   71.40%   71.37%   -0.03%     
==========================================
  Files         397      397              
  Lines       14543    14543              
==========================================
- Hits        10384    10380       -4     
- Misses       3388     3390       +2     
- Partials      771      773       +2     
Impacted Files Coverage Δ
cmd/skaffold/app/cmd/flags.go 87.50% <ø> (ø)
pkg/skaffold/initializer/analyze/directory.go 50.00% <ø> (ø)
...affold/kubernetes/portforward/kubectl_forwarder.go 67.60% <ø> (ø)
pkg/skaffold/runner/new.go 67.58% <0.00%> (ø)
pkg/skaffold/runner/render.go 12.50% <ø> (ø)
pkg/skaffold/schema/latest/config.go 58.82% <ø> (ø)
pkg/skaffold/schema/v2beta10/config.go 100.00% <ø> (ø)
pkg/skaffold/schema/v2beta11/config.go 20.58% <ø> (ø)
pkg/skaffold/schema/v2beta12/config.go 20.58% <ø> (ø)
pkg/skaffold/schema/v2beta9/config.go 100.00% <ø> (ø)
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4588f51...60b3f7d. Read the comment docs.

@gsquared94 gsquared94 added the kokoro:force-run forces a kokoro re-run on a PR label Feb 22, 2021
@kokoro-team kokoro-team removed the kokoro:force-run forces a kokoro re-run on a PR label Feb 22, 2021
@gsquared94 gsquared94 added the kokoro:force-run forces a kokoro re-run on a PR label Feb 23, 2021
@kokoro-team kokoro-team removed the kokoro:force-run forces a kokoro re-run on a PR label Feb 23, 2021
@MarlonGamez MarlonGamez merged commit 4fc162a into GoogleContainerTools:master Feb 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

make test fails in M1 macs
4 participants