-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add golint support for M1 macs (darwin/arm64 arch) #5435
Merged
MarlonGamez
merged 7 commits into
GoogleContainerTools:master
from
ricardo-larosa:golint-darwin-arm64
Feb 23, 2021
Merged
Add golint support for M1 macs (darwin/arm64 arch) #5435
MarlonGamez
merged 7 commits into
GoogleContainerTools:master
from
ricardo-larosa:golint-darwin-arm64
Feb 23, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ricardo-larosa
requested review from
chanseokoh,
loosebazooka and
a team
as code owners
February 22, 2021 10:01
ricardo-larosa
changed the title
Add support of Golint on M1 macs (darwin/arm64 arch)
Add golint support for M1 macs (darwin/arm64 arch)
Feb 22, 2021
Codecov Report
@@ Coverage Diff @@
## master #5435 +/- ##
==========================================
- Coverage 71.40% 71.37% -0.03%
==========================================
Files 397 397
Lines 14543 14543
==========================================
- Hits 10384 10380 -4
- Misses 3388 3390 +2
- Partials 771 773 +2
Continue to review full report at Codecov.
|
gsquared94
reviewed
Feb 22, 2021
Co-authored-by: Gaurav <[email protected]>
gsquared94
approved these changes
Feb 23, 2021
MarlonGamez
approved these changes
Feb 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #5434
Description
golint
version to1.37.1
which now supportsdarwin/arm64
archdarwin/arm64
tohack/install_golint.sh
defer os.Exit(0)
in cmd_test.go